* [PATCH] rds: send: Replace sg++ with sg = sg_next(sg)
@ 2020-07-08 3:42 Xu Wang
2020-07-08 5:34 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-07-08 3:42 UTC (permalink / raw)
To: santosh.shilimkar, davem, kuba, netdev, linux-rdma, rds-devel
Cc: linux-kernel, Xu Wang
Replace sg++ with sg = sg_next(sg).
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
net/rds/send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/send.c b/net/rds/send.c
index 68e2bdb08fd0..57d03a6753de 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -387,7 +387,7 @@ int rds_send_xmit(struct rds_conn_path *cp)
ret -= tmp;
if (cp->cp_xmit_data_off == sg->length) {
cp->cp_xmit_data_off = 0;
- sg++;
+ sg = sg_next(sg);
cp->cp_xmit_sg++;
BUG_ON(ret != 0 && cp->cp_xmit_sg ==
rm->data.op_nents);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rds: send: Replace sg++ with sg = sg_next(sg)
2020-07-08 3:42 [PATCH] rds: send: Replace sg++ with sg = sg_next(sg) Xu Wang
@ 2020-07-08 5:34 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2020-07-08 5:34 UTC (permalink / raw)
To: Xu Wang
Cc: santosh.shilimkar, davem, kuba, netdev, linux-rdma, rds-devel,
linux-kernel
On Wed, Jul 08, 2020 at 03:42:52AM +0000, Xu Wang wrote:
> Replace sg++ with sg = sg_next(sg).
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> net/rds/send.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/rds/send.c b/net/rds/send.c
> index 68e2bdb08fd0..57d03a6753de 100644
> --- a/net/rds/send.c
> +++ b/net/rds/send.c
> @@ -387,7 +387,7 @@ int rds_send_xmit(struct rds_conn_path *cp)
> ret -= tmp;
> if (cp->cp_xmit_data_off == sg->length) {
> cp->cp_xmit_data_off = 0;
> - sg++;
> + sg = sg_next(sg);
What about rest cases?
➜ kernel git:(rdma-next) git grep "sg++" net/rds/
net/rds/message.c: sg++;
net/rds/message.c: sg++;
net/rds/message.c: sg++;
net/rds/send.c: sg++;
net/rds/tcp_send.c: sg++;
Thanks
> cp->cp_xmit_sg++;
> BUG_ON(ret != 0 && cp->cp_xmit_sg ==
> rm->data.op_nents);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-08 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08 3:42 [PATCH] rds: send: Replace sg++ with sg = sg_next(sg) Xu Wang
2020-07-08 5:34 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).