* [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component
@ 2020-07-08 14:45 Maxime Ripard
2020-10-28 13:30 ` Dave Stevenson
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2020-07-08 14:45 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Eric Anholt
Cc: dri-devel, linux-rpi-kernel, bcm-kernel-feedback-list,
linux-arm-kernel, linux-kernel, Dave Stevenson, Tim Gover,
Phil Elwell, Maxime Ripard
Since the components for a given device in ASoC are identified by their
name, it makes sense to add one even though it's not strictly necessary.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 15a11cd4de25..a057db0d9baa 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -983,6 +983,7 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
};
static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
+ .name = "vc4-hdmi-codec-dai-component",
.controls = vc4_hdmi_audio_controls,
.num_controls = ARRAY_SIZE(vc4_hdmi_audio_controls),
.dapm_widgets = vc4_hdmi_audio_widgets,
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component
2020-07-08 14:45 [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component Maxime Ripard
@ 2020-10-28 13:30 ` Dave Stevenson
2020-10-29 9:27 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Dave Stevenson @ 2020-10-28 13:30 UTC (permalink / raw)
To: Maxime Ripard
Cc: Nicolas Saenz Julienne, Eric Anholt, DRI Development,
linux-rpi-kernel, bcm-kernel-feedback-list, linux-arm-kernel,
LKML, Tim Gover, Phil Elwell
Hi Maxime
On Wed, 8 Jul 2020 at 15:46, Maxime Ripard <maxime@cerno.tech> wrote:
>
> Since the components for a given device in ASoC are identified by their
> name, it makes sense to add one even though it's not strictly necessary.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 15a11cd4de25..a057db0d9baa 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -983,6 +983,7 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
> };
>
> static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
> + .name = "vc4-hdmi-codec-dai-component",
> .controls = vc4_hdmi_audio_controls,
> .num_controls = ARRAY_SIZE(vc4_hdmi_audio_controls),
> .dapm_widgets = vc4_hdmi_audio_widgets,
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component
2020-10-28 13:30 ` Dave Stevenson
@ 2020-10-29 9:27 ` Maxime Ripard
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2020-10-29 9:27 UTC (permalink / raw)
To: Dave Stevenson
Cc: Nicolas Saenz Julienne, Eric Anholt, DRI Development,
linux-rpi-kernel, bcm-kernel-feedback-list, linux-arm-kernel,
LKML, Tim Gover, Phil Elwell
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Wed, Oct 28, 2020 at 01:30:32PM +0000, Dave Stevenson wrote:
> Hi Maxime
>
> On Wed, 8 Jul 2020 at 15:46, Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > Since the components for a given device in ASoC are identified by their
> > name, it makes sense to add one even though it's not strictly necessary.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Applied, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-29 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08 14:45 [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component Maxime Ripard
2020-10-28 13:30 ` Dave Stevenson
2020-10-29 9:27 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).