* linux-next: build warning after merge of the clk tree
@ 2020-06-29 23:53 Stephen Rothwell
2020-06-30 8:11 ` Maxime Ripard
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2020-06-29 23:53 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Maxime Ripard
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
Hi all,
After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/bcm/clk-bcm2711-dvp.o
Introduced by commit
1bc95972715a ("clk: bcm: Add BCM2711 DVP driver")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2020-06-29 23:53 linux-next: build warning after merge of the clk tree Stephen Rothwell
@ 2020-06-30 8:11 ` Maxime Ripard
2020-07-08 11:10 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: Maxime Ripard @ 2020-06-30 8:11 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mike Turquette, Stephen Boyd, Linux Next Mailing List,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Hi,
On Tue, Jun 30, 2020 at 09:53:41AM +1000, Stephen Rothwell wrote:
> After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/bcm/clk-bcm2711-dvp.o
>
> Introduced by commit
>
> 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver")
I've posted a patch solving this already:
https://lore.kernel.org/linux-clk/20200626112513.90816-1-maxime@cerno.tech/
And it's supposed to be in clk-next since friday, but it looks like
stephen didn't push his branch?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2020-06-30 8:11 ` Maxime Ripard
@ 2020-07-08 11:10 ` Stephen Rothwell
2020-07-16 0:25 ` Stephen Boyd
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2020-07-08 11:10 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Maxime Ripard, Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Hi all,
On Tue, 30 Jun 2020 10:11:15 +0200 Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Tue, Jun 30, 2020 at 09:53:41AM +1000, Stephen Rothwell wrote:
> > After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/bcm/clk-bcm2711-dvp.o
> >
> > Introduced by commit
> >
> > 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver")
>
> I've posted a patch solving this already:
> https://lore.kernel.org/linux-clk/20200626112513.90816-1-maxime@cerno.tech/
>
> And it's supposed to be in clk-next since friday, but it looks like
> stephen didn't push his branch?
I am still getting this warning.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2020-07-08 11:10 ` Stephen Rothwell
@ 2020-07-16 0:25 ` Stephen Boyd
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Boyd @ 2020-07-16 0:25 UTC (permalink / raw)
To: Mike Turquette, Stephen Rothwell
Cc: Maxime Ripard, Linux Next Mailing List, Linux Kernel Mailing List
Quoting Stephen Rothwell (2020-07-08 04:10:44)
> Hi all,
>
> On Tue, 30 Jun 2020 10:11:15 +0200 Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Tue, Jun 30, 2020 at 09:53:41AM +1000, Stephen Rothwell wrote:
> > > After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
> > > produced this warning:
> > >
> > > WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/bcm/clk-bcm2711-dvp.o
> > >
> > > Introduced by commit
> > >
> > > 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver")
> >
> > I've posted a patch solving this already:
> > https://lore.kernel.org/linux-clk/20200626112513.90816-1-maxime@cerno.tech/
> >
> > And it's supposed to be in clk-next since friday, but it looks like
> > stephen didn't push his branch?
>
> I am still getting this warning.
>
Sorry I forgot to push it out. Should be fixed now.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2019-08-15 23:57 Stephen Rothwell
@ 2019-08-16 18:10 ` Stephen Boyd
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Boyd @ 2019-08-16 18:10 UTC (permalink / raw)
To: Mike Turquette, Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Manivannan Sadhasivam
Quoting Stephen Rothwell (2019-08-15 16:57:32)
> Hi all,
>
> After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/clk/actions/owl-common.c: In function 'owl_clk_probe':
> drivers/clk/actions/owl-common.c:71:24: warning: 'hw' may be used uninitialized in this function [-Wmaybe-uninitialized]
> const char *name = hw->init->name;
> ~~^~~~~~
>
> Introduced by commit
>
> 20cac6d02815 ("clk: actions: Don't reference clk_init_data after registration")
>
> Clearly not a false positive. :-(
>
Thanks. I fixed it now.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the clk tree
@ 2019-08-15 23:57 Stephen Rothwell
2019-08-16 18:10 ` Stephen Boyd
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2019-08-15 23:57 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Manivannan Sadhasivam
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
Hi all,
After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/clk/actions/owl-common.c: In function 'owl_clk_probe':
drivers/clk/actions/owl-common.c:71:24: warning: 'hw' may be used uninitialized in this function [-Wmaybe-uninitialized]
const char *name = hw->init->name;
~~^~~~~~
Introduced by commit
20cac6d02815 ("clk: actions: Don't reference clk_init_data after registration")
Clearly not a false positive. :-(
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2019-04-30 1:44 ` Anson Huang
@ 2019-04-30 5:56 ` Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2019-04-30 5:56 UTC (permalink / raw)
To: Anson Huang
Cc: Mike Turquette, Stephen Boyd, Linux Next Mailing List,
Linux Kernel Mailing List, Gustavo A. R. Silva, Kees Cook
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
Hi Anson,
On Tue, 30 Apr 2019 01:44:58 +0000 Anson Huang <anson.huang@nxp.com> wrote:
>
> Thanks for notice.
> As it is intentional, I will send out a patch to add "/* fall through */" to avoid this build warning,
Excellent, thanks.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: linux-next: build warning after merge of the clk tree
2019-04-30 0:19 Stephen Rothwell
@ 2019-04-30 1:44 ` Anson Huang
2019-04-30 5:56 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: Anson Huang @ 2019-04-30 1:44 UTC (permalink / raw)
To: Stephen Rothwell, Mike Turquette, Stephen Boyd
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Gustavo A. R. Silva, Kees Cook
Hi, Stephen
Thanks for notice.
As it is intentional, I will send out a patch to add "/* fall through */" to avoid this build warning,
Anson.
> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Tuesday, April 30, 2019 8:20 AM
> To: Mike Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
> List <linux-kernel@vger.kernel.org>; Anson Huang <anson.huang@nxp.com>;
> Gustavo A. R. Silva <gustavo@embeddedor.com>; Kees Cook
> <keescook@chromium.org>
> Subject: linux-next: build warning after merge of the clk tree
>
> Hi all,
>
> After merging the clk tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-
> Wimplicit-fallthrough=]
> pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> ^
> drivers/clk/imx/clk-pllv3.c:454:2: note: here
> case IMX_PLLV3_AV:
> ^~~~
>
> Introduced by commit
>
> 01d0a541ff4b ("clk: imx: correct i.MX7D AV PLL num/denom offset")
>
> I get this warning because I am building with -Wimplicit-fallthrough in
> attempt to catch new additions early. The gcc warning can be turned off by
> adding a /* fall through */ comment at the point the fall through happens
> (assuming that the fall through is intentional).
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the clk tree
@ 2019-04-30 0:19 Stephen Rothwell
2019-04-30 1:44 ` Anson Huang
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2019-04-30 0:19 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Anson Huang,
Gustavo A. R. Silva, Kees Cook
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
Hi all,
After merging the clk tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
^
drivers/clk/imx/clk-pllv3.c:454:2: note: here
case IMX_PLLV3_AV:
^~~~
Introduced by commit
01d0a541ff4b ("clk: imx: correct i.MX7D AV PLL num/denom offset")
I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early. The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2018-10-17 21:51 Stephen Rothwell
@ 2018-10-18 18:21 ` Stephen Boyd
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Boyd @ 2018-10-18 18:21 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd, Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Taniya Das,
Craig Tatlor, Rob Herring
Quoting Stephen Rothwell (2018-10-17 14:51:53)
> Hi all,
>
> After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/qcom/gcc-sdm660.o
> see include/linux/module.h for more information
>
> Introduced by commit
>
> f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660")
>
Thanks! I silenced it.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the clk tree
@ 2018-10-17 21:51 Stephen Rothwell
2018-10-18 18:21 ` Stephen Boyd
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2018-10-17 21:51 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Taniya Das,
Craig Tatlor, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
Hi all,
After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/qcom/gcc-sdm660.o
see include/linux/module.h for more information
Introduced by commit
f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2016-12-12 8:05 ` Boris Brezillon
@ 2016-12-12 8:19 ` Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2016-12-12 8:19 UTC (permalink / raw)
To: Boris Brezillon
Cc: Mike Turquette, Stephen Boyd, linux-next, linux-kernel, Eric Anholt
Hi Boris,
On Mon, 12 Dec 2016 09:05:21 +0100 Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
> May I ask which toolchain you're using, because my gcc failed to detect
> this uninitialized variable (and this is not the first time I have this
> problem).
I use a powerpc-le hosted cross compiler gcc-5.2.0.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2016-12-11 21:39 Stephen Rothwell
@ 2016-12-12 8:05 ` Boris Brezillon
2016-12-12 8:19 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: Boris Brezillon @ 2016-12-12 8:05 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mike Turquette, Stephen Boyd, linux-next, linux-kernel, Eric Anholt
+Eric
Hi Stephen,
On Mon, 12 Dec 2016 08:39:44 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the clk tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/clk/bcm/clk-bcm2835.c: In function 'bcm2835_clock_determine_rate':
> drivers/clk/bcm/clk-bcm2835.c:1069:18: warning: 'best_rate' may be used uninitialized in this function [-Wmaybe-uninitialized]
> *prate = curdiv * best_rate;
> ^
> drivers/clk/bcm/clk-bcm2835.c:1032:16: note: 'best_rate' was declared here
> unsigned long best_rate;
> ^
>
> Introduced by commit
>
> 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks")
>
Thanks for the report (I just sent a patch fixing this warning).
May I ask which toolchain you're using, because my gcc failed to detect
this uninitialized variable (and this is not the first time I have this
problem).
Regards,
Boris
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the clk tree
@ 2016-12-11 21:39 Stephen Rothwell
2016-12-12 8:05 ` Boris Brezillon
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2016-12-11 21:39 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd; +Cc: linux-next, linux-kernel, Boris Brezillon
Hi all,
After merging the clk tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/clk/bcm/clk-bcm2835.c: In function 'bcm2835_clock_determine_rate':
drivers/clk/bcm/clk-bcm2835.c:1069:18: warning: 'best_rate' may be used uninitialized in this function [-Wmaybe-uninitialized]
*prate = curdiv * best_rate;
^
drivers/clk/bcm/clk-bcm2835.c:1032:16: note: 'best_rate' was declared here
unsigned long best_rate;
^
Introduced by commit
155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build warning after merge of the clk tree
2015-05-06 4:05 Stephen Rothwell
@ 2015-05-06 4:41 ` Stephen Boyd
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Boyd @ 2015-05-06 4:41 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Mike Turquette, Heiko Stuebner, linux-next, linux-kernel
On 05/06, Stephen Rothwell wrote:
> Hi all,
>
> After merging the clk tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/clk/clk.c:2231:13: warning: 'clk_is_orphan' defined but not used [-Wunused-function]
> static bool clk_is_orphan(const struct clk *clk)
> ^
>
> Introduced by commit ece3ffbe1b7b ("clk: prevent orphan clocks from
> being used").
>
> CONFIG_OF is not set for this build ...
Thanks for the report. kbuild robot also reported this problem
the other day. We came up with a way to not have this function at
all though so this problem should go away tomorrow.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the clk tree
@ 2015-05-06 4:05 Stephen Rothwell
2015-05-06 4:41 ` Stephen Boyd
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2015-05-06 4:05 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd, Heiko Stuebner; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
Hi all,
After merging the clk tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/clk/clk.c:2231:13: warning: 'clk_is_orphan' defined but not used [-Wunused-function]
static bool clk_is_orphan(const struct clk *clk)
^
Introduced by commit ece3ffbe1b7b ("clk: prevent orphan clocks from
being used").
CONFIG_OF is not set for this build ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-07-16 0:25 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 23:53 linux-next: build warning after merge of the clk tree Stephen Rothwell
2020-06-30 8:11 ` Maxime Ripard
2020-07-08 11:10 ` Stephen Rothwell
2020-07-16 0:25 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2019-08-15 23:57 Stephen Rothwell
2019-08-16 18:10 ` Stephen Boyd
2019-04-30 0:19 Stephen Rothwell
2019-04-30 1:44 ` Anson Huang
2019-04-30 5:56 ` Stephen Rothwell
2018-10-17 21:51 Stephen Rothwell
2018-10-18 18:21 ` Stephen Boyd
2016-12-11 21:39 Stephen Rothwell
2016-12-12 8:05 ` Boris Brezillon
2016-12-12 8:19 ` Stephen Rothwell
2015-05-06 4:05 Stephen Rothwell
2015-05-06 4:41 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).