* [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()
@ 2020-07-09 8:08 Xu Wang
2020-07-09 14:49 ` Moore, Robert
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-07-09 8:08 UTC (permalink / raw)
To: robert.moore, erik.kaneda, rafael.j.wysocki, lenb, vulab,
linux-acpi, devel
Cc: linux-kernel
Remove extra brackets.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
tools/power/acpi/os_specific/service_layers/osunixmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/power/acpi/os_specific/service_layers/osunixmap.c b/tools/power/acpi/os_specific/service_layers/osunixmap.c
index c565546e85bc..52f3e70b5c81 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixmap.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixmap.c
@@ -70,7 +70,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
fd = open(SYSTEM_MEMORY, O_RDONLY | O_BINARY);
if (fd < 0) {
fprintf(stderr, "Cannot open %s\n", SYSTEM_MEMORY);
- return (NULL);
+ return NULL;
}
/* Align the offset to use mmap */
@@ -85,7 +85,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
if (mapped_memory == MAP_FAILED) {
fprintf(stderr, "Cannot map %s\n", SYSTEM_MEMORY);
close(fd);
- return (NULL);
+ return NULL;
}
close(fd);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()
2020-07-09 8:08 [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory() Xu Wang
@ 2020-07-09 14:49 ` Moore, Robert
0 siblings, 0 replies; 2+ messages in thread
From: Moore, Robert @ 2020-07-09 14:49 UTC (permalink / raw)
To: Xu Wang, Kaneda, Erik, Wysocki, Rafael J, lenb, linux-acpi, devel
Cc: linux-kernel
- return (NULL);
+ return NULL;
This is the ACPICA coding standard, and it does not affect anything.
Bob
-----Original Message-----
From: Xu Wang <vulab@iscas.ac.cn>
Sent: Thursday, July 09, 2020 1:08 AM
To: Moore, Robert <robert.moore@intel.com>; Kaneda, Erik <erik.kaneda@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; lenb@kernel.org; vulab@iscas.ac.cn; linux-acpi@vger.kernel.org; devel@acpica.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()
Remove extra brackets.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
tools/power/acpi/os_specific/service_layers/osunixmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/power/acpi/os_specific/service_layers/osunixmap.c b/tools/power/acpi/os_specific/service_layers/osunixmap.c
index c565546e85bc..52f3e70b5c81 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixmap.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixmap.c
@@ -70,7 +70,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
fd = open(SYSTEM_MEMORY, O_RDONLY | O_BINARY);
if (fd < 0) {
fprintf(stderr, "Cannot open %s\n", SYSTEM_MEMORY);
- return (NULL);
+ return NULL;
}
/* Align the offset to use mmap */
@@ -85,7 +85,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
if (mapped_memory == MAP_FAILED) {
fprintf(stderr, "Cannot map %s\n", SYSTEM_MEMORY);
close(fd);
- return (NULL);
+ return NULL;
}
close(fd);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-09 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 8:08 [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory() Xu Wang
2020-07-09 14:49 ` Moore, Robert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).