linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble
@ 2020-07-08  0:25 Chris Healy
  2020-07-13  7:34 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Healy @ 2020-07-08  0:25 UTC (permalink / raw)
  To: robh+dt, shawnguo, s.hauer, festevam, linux-imx, stefan,
	devicetree, linux-arm-kernel, linux-kernel, andrew
  Cc: Chris Healy

Update MDIO configuration with ZII devices to fully utilize
MDIO endpoint capabilities.  All devices support 12.5MHz clock and
don't require MDIO preable.

Signed-off-by: Chris Healy <cphealy@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
v2:
- Fix subject line to reference ZII:
- Get rid of "=<1>;" from suppress-preamble lines

 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi   | 2 ++
 arch/arm/boot/dts/vf610-zii-cfu1.dts      | 2 ++
 arch/arm/boot/dts/vf610-zii-dev.dtsi      | 2 ++
 arch/arm/boot/dts/vf610-zii-spb4.dts      | 2 ++
 arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts  | 2 ++
 arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 2 ++
 6 files changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 20350e803377..58cc421042e1 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -720,6 +720,8 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
+		suppress-preamble;
+		clock-frequency = <12500000>;
 
 		switch: switch@0 {
 			compatible = "marvell,mv88e6085";
diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
index ce1920c052fc..c27cacbe6a73 100644
--- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
+++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
@@ -159,6 +159,8 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
+		suppress-preamble;
+		clock-frequency = <12500000>;
 
 		switch0: switch0@0 {
 			compatible = "marvell,mv88e6085";
diff --git a/arch/arm/boot/dts/vf610-zii-dev.dtsi b/arch/arm/boot/dts/vf610-zii-dev.dtsi
index 95d0060fb56c..9694d3b53607 100644
--- a/arch/arm/boot/dts/vf610-zii-dev.dtsi
+++ b/arch/arm/boot/dts/vf610-zii-dev.dtsi
@@ -138,6 +138,8 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
+		suppress-preamble;
+		clock-frequency = <12500000>;
 	};
 };
 
diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
index 55b4201e27f6..d2ad07ed5318 100644
--- a/arch/arm/boot/dts/vf610-zii-spb4.dts
+++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
@@ -120,6 +120,8 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
+		suppress-preamble;
+		clock-frequency = <12500000>;
 
 		switch0: switch0@0 {
 			compatible = "marvell,mv88e6190";
diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
index a6c22a79779e..0bb3dcff0b79 100644
--- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
+++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
@@ -106,6 +106,8 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
+		suppress-preamble;
+		clock-frequency = <12500000>;
 
 		switch0: switch0@0 {
 			compatible = "marvell,mv88e6190";
diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
index 3d05c894bdc0..e12e11805b71 100644
--- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
+++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
@@ -134,6 +134,8 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
+		suppress-preamble;
+		clock-frequency = <12500000>;
 
 		switch0: switch0@0 {
 			compatible = "marvell,mv88e6190";
-- 
2.21.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble
  2020-07-08  0:25 [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble Chris Healy
@ 2020-07-13  7:34 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2020-07-13  7:34 UTC (permalink / raw)
  To: Chris Healy
  Cc: robh+dt, s.hauer, festevam, linux-imx, stefan, devicetree,
	linux-arm-kernel, linux-kernel, andrew

On Tue, Jul 07, 2020 at 05:25:00PM -0700, Chris Healy wrote:
> Update MDIO configuration with ZII devices to fully utilize
> MDIO endpoint capabilities.  All devices support 12.5MHz clock and
> don't require MDIO preable.
> 
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> v2:
> - Fix subject line to reference ZII:
> - Get rid of "=<1>;" from suppress-preamble lines
> 
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi   | 2 ++
>  arch/arm/boot/dts/vf610-zii-cfu1.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-dev.dtsi      | 2 ++
>  arch/arm/boot/dts/vf610-zii-spb4.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts  | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 2 ++
>  6 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 20350e803377..58cc421042e1 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -720,6 +720,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;

We usually have 'status' at end of property list, so please move them
up.

Shawn

>  
>  		switch: switch@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> index ce1920c052fc..c27cacbe6a73 100644
> --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> @@ -159,6 +159,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-dev.dtsi b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> index 95d0060fb56c..9694d3b53607 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev.dtsi
> +++ b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> @@ -138,6 +138,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  	};
>  };
>  
> diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
> index 55b4201e27f6..d2ad07ed5318 100644
> --- a/arch/arm/boot/dts/vf610-zii-spb4.dts
> +++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
> @@ -120,6 +120,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> index a6c22a79779e..0bb3dcff0b79 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> @@ -106,6 +106,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> index 3d05c894bdc0..e12e11805b71 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> @@ -134,6 +134,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> -- 
> 2.21.3
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-13  7:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08  0:25 [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble Chris Healy
2020-07-13  7:34 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).