From: Shawn Guo <shawnguo@kernel.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Philippe Schenker <philippe.schenker@toradex.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability
Date: Mon, 13 Jul 2020 18:52:20 +0800 [thread overview]
Message-ID: <20200713105219.GN15718@dragon> (raw)
In-Reply-To: <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de>
On Mon, Jul 13, 2020 at 11:46:04AM +0200, Ahmad Fatoum wrote:
> Hello Philippe,
>
> On 7/10/20 3:24 PM, Philippe Schenker wrote:
> > Since the runtime-pm wakeup bug was fixed in
> > drivers/usb/chipidea/core.c usb dual-role host/device switching is
> > working. So make use of it.
> >
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> >
> > ---
> >
> > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 9 +++++++++
> > arch/arm/boot/dts/imx7-colibri.dtsi | 4 ++--
> > 2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
> > index 97601375f264..db56a532a34a 100644
> > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
> > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
> > @@ -20,6 +20,14 @@ clk16m: clk16m {
> > clock-frequency = <16000000>;
> > };
> >
> > + extcon_usbc_det: usbc_det {
> > + compatible = "linux,extcon-usb-gpio";
>
> According to 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver"):
> "the old way using extcon to support USB Dual-Role switch is now deprecated
> when use Type-B connector."
>
> Have you considered using a compatible = "gpio-usb-b-connector" child node instead?
I dropped patch #2 and #3 for now.
Shawn
next prev parent reply other threads:[~2020-07-13 10:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 13:24 [PATCH 1/3] ARM: dts: colibri-imx6: remove pinctrl-names orphan Philippe Schenker
2020-07-10 13:24 ` [PATCH 2/3] ARM: dts: colibri-imx6: add usb dual-role switch capability Philippe Schenker
2020-07-10 13:45 ` Oleksandr Suvorov
2020-07-10 13:24 ` [PATCH 3/3] ARM: dts: colibri-imx7: " Philippe Schenker
2020-07-10 13:47 ` Oleksandr Suvorov
2020-07-13 9:46 ` Ahmad Fatoum
2020-07-13 10:52 ` Shawn Guo [this message]
2020-07-13 11:53 ` Philippe Schenker
2020-07-14 7:55 ` Ahmad Fatoum
2020-07-14 8:20 ` Philippe Schenker
2020-07-20 2:11 ` Shawn Guo
2020-07-20 7:37 ` Philippe Schenker
2020-07-23 11:44 ` Philippe Schenker
2020-07-10 13:42 ` [PATCH 1/3] ARM: dts: colibri-imx6: remove pinctrl-names orphan Oleksandr Suvorov
2020-07-13 9:01 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713105219.GN15718@dragon \
--to=shawnguo@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).