From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Philippe Schenker <philippe.schenker@toradex.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability
Date: Tue, 14 Jul 2020 09:55:25 +0200 [thread overview]
Message-ID: <7e6f8135-120f-0831-20ad-25648ea646b8@pengutronix.de> (raw)
In-Reply-To: <c76c0fd056512a3f8e24bf06e7bb7e1650090609.camel@toradex.com>
Hello Philippe,
On 7/13/20 1:53 PM, Philippe Schenker wrote:
> On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote:
>> Hello Philippe,
>>
>>> + extcon_usbc_det: usbc_det {
>>> + compatible = "linux,extcon-usb-gpio";
>>
>> According to 4602f3bff266 ("usb: common: add USB GPIO based connection
>> detection driver"):
>> "the old way using extcon to support USB Dual-Role switch is now
>> deprecated
>> when use Type-B connector."
>>
>> Have you considered using a compatible = "gpio-usb-b-connector" child
>> node instead?
>>
>> Cheers,
>> Ahmad
>
> Thanks for the Hint Ahmad,
>
> I already tried and just now tried again but it doesn't work on our
> hardware. Are you sure this works with chipidea driver?
I haven't, just wanted to point its existence out in case you didn't know.
Seems we need to call of_platform_populate somewhere in the driver.
Unsure what other changes are necessary.
> Should this new usb-connector stuff work in general with every old
> driver?
If the driver support isn't there yet, I think use of extcon is fine as is.
Thanks
Ahmad
>
> Philippe
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-07-14 7:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 13:24 [PATCH 1/3] ARM: dts: colibri-imx6: remove pinctrl-names orphan Philippe Schenker
2020-07-10 13:24 ` [PATCH 2/3] ARM: dts: colibri-imx6: add usb dual-role switch capability Philippe Schenker
2020-07-10 13:45 ` Oleksandr Suvorov
2020-07-10 13:24 ` [PATCH 3/3] ARM: dts: colibri-imx7: " Philippe Schenker
2020-07-10 13:47 ` Oleksandr Suvorov
2020-07-13 9:46 ` Ahmad Fatoum
2020-07-13 10:52 ` Shawn Guo
2020-07-13 11:53 ` Philippe Schenker
2020-07-14 7:55 ` Ahmad Fatoum [this message]
2020-07-14 8:20 ` Philippe Schenker
2020-07-20 2:11 ` Shawn Guo
2020-07-20 7:37 ` Philippe Schenker
2020-07-23 11:44 ` Philippe Schenker
2020-07-10 13:42 ` [PATCH 1/3] ARM: dts: colibri-imx6: remove pinctrl-names orphan Oleksandr Suvorov
2020-07-13 9:01 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6f8135-120f-0831-20ad-25648ea646b8@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).