* [PATCH] iwlwifi: Don't IWL_WARN on FW reconfiguration
@ 2019-10-17 14:48 Chris Down
2019-10-17 14:53 ` Chris Down
0 siblings, 1 reply; 4+ messages in thread
From: Chris Down @ 2019-10-17 14:48 UTC (permalink / raw)
To: linux-wireless; +Cc: Shahar S Matityahu, Luca Coelho, linux-kernel
IWL_WARN seems excessive here since this can happen during normal
operation. Every time I connect to a new network with 8086:24fd I get
this as KERN_WARNING on the console, which mildly distracts from other
more pressing messages. For example:
% sudo journalctl _TRANSPORT=kernel | grep -c 'FW already configured'
403
Signed-off-by: Chris Down <chris@chrisdown.name>
Cc: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
---
drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
index 5c8602de9168..ac7ecb76d964 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
@@ -2264,7 +2264,7 @@ int iwl_fw_start_dbg_conf(struct iwl_fw_runtime *fwrt, u8 conf_id)
return -EINVAL;
if (fwrt->dump.conf != FW_DBG_INVALID)
- IWL_WARN(fwrt, "FW already configured (%d) - re-configuring\n",
+ IWL_INFO(fwrt, "FW already configured (%d) - re-configuring\n",
fwrt->dump.conf);
/* Send all HCMDs for configuring the FW debug */
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iwlwifi: Don't IWL_WARN on FW reconfiguration
2019-10-17 14:48 [PATCH] iwlwifi: Don't IWL_WARN on FW reconfiguration Chris Down
@ 2019-10-17 14:53 ` Chris Down
2020-07-13 11:51 ` Chris Down
0 siblings, 1 reply; 4+ messages in thread
From: Chris Down @ 2019-10-17 14:53 UTC (permalink / raw)
To: linux-wireless; +Cc: Shahar S Matityahu, Luca Coelho, linux-kernel
To be more clear in case this actually is representative of a real problem
(although I doubt it since this seems present on every device like this I
encountered), it's always FW_DBG_START_FROM_ALIVE:
% sudo journalctl _TRANSPORT=kernel -o cat | grep 'FW already configured' | sort | uniq -c
403 iwlwifi 0000:3a:00.0: FW already configured (0) - re-configuring
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iwlwifi: Don't IWL_WARN on FW reconfiguration
2019-10-17 14:53 ` Chris Down
@ 2020-07-13 11:51 ` Chris Down
2020-07-13 17:41 ` Johannes Hirte
0 siblings, 1 reply; 4+ messages in thread
From: Chris Down @ 2020-07-13 11:51 UTC (permalink / raw)
To: linux-wireless; +Cc: Shahar S Matityahu, Luca Coelho, linux-kernel
Just to check in again since this is still happening: is this expected?
I expect that if this is IWL_WARN, it should indicate some unexpected or
non-ideal state, but the card seems to operate just fine afterwards.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iwlwifi: Don't IWL_WARN on FW reconfiguration
2020-07-13 11:51 ` Chris Down
@ 2020-07-13 17:41 ` Johannes Hirte
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Hirte @ 2020-07-13 17:41 UTC (permalink / raw)
To: Chris Down; +Cc: linux-wireless, Shahar S Matityahu, Luca Coelho, linux-kernel
On 2020 Jul 13, Chris Down wrote:
> Just to check in again since this is still happening: is this expected?
>
> I expect that if this is IWL_WARN, it should indicate some unexpected or
> non-ideal state, but the card seems to operate just fine afterwards.
I'm confused too, cause I'm seeing this on an AC 8260 now, whereas in the
past there wasn't such a message. Is this something the user should be
aware of? If not, I'm with Chris that this should be silenced.
--
Regards,
Johannes Hirte
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-13 17:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 14:48 [PATCH] iwlwifi: Don't IWL_WARN on FW reconfiguration Chris Down
2019-10-17 14:53 ` Chris Down
2020-07-13 11:51 ` Chris Down
2020-07-13 17:41 ` Johannes Hirte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).