* [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped
@ 2020-07-14 21:37 Bard Liao
2020-07-14 21:37 ` [PATCH 1/2] soundwire: sdw.h: fix PRBS/Static_1 swapped definitions Bard Liao
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bard Liao @ 2020-07-14 21:37 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, linux-kernel, tiwai, broonie, gregkh, jank,
srinivas.kandagatla, rander.wang, ranjani.sridharan, hui.wang,
pierre-louis.bossart, sanyog.r.kale, slawomir.blauciak,
mengdong.lin, bard.liao
Fix PRBS/Static_1 swapped definitions and indentation in sdw.h
Pierre-Louis Bossart (2):
soundwire: sdw.h: fix PRBS/Static_1 swapped definitions
soundwire: sdw.h: fix indentation
include/linux/soundwire/sdw.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] soundwire: sdw.h: fix PRBS/Static_1 swapped definitions
2020-07-14 21:37 [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped Bard Liao
@ 2020-07-14 21:37 ` Bard Liao
2020-07-14 21:37 ` [PATCH 2/2] soundwire: sdw.h: fix indentation Bard Liao
2020-07-15 9:52 ` [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2020-07-14 21:37 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, linux-kernel, tiwai, broonie, gregkh, jank,
srinivas.kandagatla, rander.wang, ranjani.sridharan, hui.wang,
pierre-louis.bossart, sanyog.r.kale, slawomir.blauciak,
mengdong.lin, bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Table 110 "Port Data Modes" of the SoundWire 1.2 specification lists
PRBS as b01 and Static_1 as b11. The existing headers swapped the two
values, fix.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
include/linux/soundwire/sdw.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index 4057adf7f049..6452bac957b3 100644
--- a/include/linux/soundwire/sdw.h
+++ b/include/linux/soundwire/sdw.h
@@ -152,19 +152,19 @@ enum sdw_data_direction {
*
* @SDW_PORT_DATA_MODE_NORMAL: Normal data mode where audio data is received
* and transmitted.
+ * @SDW_PORT_DATA_MODE_PRBS: Test mode which uses a PRBS generator to produce
+ * a pseudo random data pattern that is transferred
+ * @SDW_PORT_DATA_MODE_STATIC_0: Simple test mode which uses static value of
+ * logic 0. The encoding will result in no signal transitions
* @SDW_PORT_DATA_MODE_STATIC_1: Simple test mode which uses static value of
* logic 1. The encoding will result in signal transitions at every bitslot
* owned by this Port
- * @SDW_PORT_DATA_MODE_STATIC_0: Simple test mode which uses static value of
- * logic 0. The encoding will result in no signal transitions
- * @SDW_PORT_DATA_MODE_PRBS: Test mode which uses a PRBS generator to produce
- * a pseudo random data pattern that is transferred
*/
enum sdw_port_data_mode {
SDW_PORT_DATA_MODE_NORMAL = 0,
- SDW_PORT_DATA_MODE_STATIC_1 = 1,
+ SDW_PORT_DATA_MODE_PRBS = 1,
SDW_PORT_DATA_MODE_STATIC_0 = 2,
- SDW_PORT_DATA_MODE_PRBS = 3,
+ SDW_PORT_DATA_MODE_STATIC_1 = 3,
};
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] soundwire: sdw.h: fix indentation
2020-07-14 21:37 [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped Bard Liao
2020-07-14 21:37 ` [PATCH 1/2] soundwire: sdw.h: fix PRBS/Static_1 swapped definitions Bard Liao
@ 2020-07-14 21:37 ` Bard Liao
2020-07-15 9:52 ` [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2020-07-14 21:37 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, linux-kernel, tiwai, broonie, gregkh, jank,
srinivas.kandagatla, rander.wang, ranjani.sridharan, hui.wang,
pierre-louis.bossart, sanyog.r.kale, slawomir.blauciak,
mengdong.lin, bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Not sure how this went undetected for years.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
include/linux/soundwire/sdw.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index 6452bac957b3..76052f12c9f7 100644
--- a/include/linux/soundwire/sdw.h
+++ b/include/linux/soundwire/sdw.h
@@ -88,10 +88,10 @@ enum sdw_slave_status {
* @SDW_CLK_POST_DEPREPARE: post clock stop de-prepare
*/
enum sdw_clk_stop_type {
- SDW_CLK_PRE_PREPARE = 0,
- SDW_CLK_POST_PREPARE,
- SDW_CLK_PRE_DEPREPARE,
- SDW_CLK_POST_DEPREPARE,
+ SDW_CLK_PRE_PREPARE = 0,
+ SDW_CLK_POST_PREPARE,
+ SDW_CLK_PRE_DEPREPARE,
+ SDW_CLK_POST_DEPREPARE,
};
/**
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped
2020-07-14 21:37 [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped Bard Liao
2020-07-14 21:37 ` [PATCH 1/2] soundwire: sdw.h: fix PRBS/Static_1 swapped definitions Bard Liao
2020-07-14 21:37 ` [PATCH 2/2] soundwire: sdw.h: fix indentation Bard Liao
@ 2020-07-15 9:52 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-07-15 9:52 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, linux-kernel, tiwai, broonie, gregkh, jank,
srinivas.kandagatla, rander.wang, ranjani.sridharan, hui.wang,
pierre-louis.bossart, sanyog.r.kale, slawomir.blauciak,
mengdong.lin, bard.liao
On 15-07-20, 05:37, Bard Liao wrote:
> Fix PRBS/Static_1 swapped definitions and indentation in sdw.h
Applied both, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-15 9:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 21:37 [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped Bard Liao
2020-07-14 21:37 ` [PATCH 1/2] soundwire: sdw.h: fix PRBS/Static_1 swapped definitions Bard Liao
2020-07-14 21:37 ` [PATCH 2/2] soundwire: sdw.h: fix indentation Bard Liao
2020-07-15 9:52 ` [PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).