[PATCH] kobject: remove unused kobject action

[PATCH] kobject: remove unused kobject action

[Garrit Franke]

I noticed that the KOBJ_MAX action is never used. Does it serve any
purpose, or can it be removed? As far as I know, Kobjects shouldn't be
used for drivers and more higher level abstraction layers, so I figured
it isn't used by user-provided code either.

Regards
Garrit Franke

Signed-off-by: Garrit Franke <garritfranke@gmail.com>
---
 include/linux/kobject.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index 6cba088bee24..fd99c5d2d8b7 100644
--- a/include/linux/kobject.h
+++ b/include/linux/kobject.h
@@ -58,8 +58,7 @@ enum kobject_action {
 	KOBJ_ONLINE,
 	KOBJ_OFFLINE,
 	KOBJ_BIND,
-	KOBJ_UNBIND,
-	KOBJ_MAX
+	KOBJ_UNBIND
 };
 
 struct kobject {
-- 
2.25.1

Re: [PATCH] kobject: remove unused kobject action

[Greg KH]

On Mon, Jul 13, 2020 at 09:15:10PM +0200, Garrit Franke wrote:
> I noticed that the KOBJ_MAX action is never used. Does it serve any
> purpose, or can it be removed?

Don't ask questions in a changelog comment that you don't also answer :)

> As far as I know, Kobjects shouldn't be
> used for drivers and more higher level abstraction layers, so I figured
> it isn't used by user-provided code either.

Userspace sees these uevents, right?

> 
> Regards
> Garrit Franke

This isn't needed in a changelog text.

Try running and testing this a bit more before sending it for inclusion
please.

> 
> Signed-off-by: Garrit Franke <garritfranke@gmail.com>
> ---
>  include/linux/kobject.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/kobject.h b/include/linux/kobject.h
> index 6cba088bee24..fd99c5d2d8b7 100644
> --- a/include/linux/kobject.h
> +++ b/include/linux/kobject.h
> @@ -58,8 +58,7 @@ enum kobject_action {
>  	KOBJ_ONLINE,
>  	KOBJ_OFFLINE,
>  	KOBJ_BIND,
> -	KOBJ_UNBIND,
> -	KOBJ_MAX
> +	KOBJ_UNBIND

No need to drop that trailing ','

thanks,

greg k-h

[PATCH v2] kobject: remove unused KOBJ_MAX action

[Garrit Franke]

The loop in lib/kobject_uevent.c that checked for KOBJ_MAX is no longer present, we do
a much more sane ARRAY_SIZE() check instead (see 5c5daf657cb5).
Therefore, the KOBJ_MAX is not used anymore.

Signed-off-by: Garrit Franke <garritfranke@gmail.com>
---
 include/linux/kobject.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index 6cba088bee24..ea30529fba08 100644
--- a/include/linux/kobject.h
+++ b/include/linux/kobject.h
@@ -59,7 +59,6 @@ enum kobject_action {
 	KOBJ_OFFLINE,
 	KOBJ_BIND,
 	KOBJ_UNBIND,
-	KOBJ_MAX
 };
 
 struct kobject {
-- 
2.25.1

Re: [PATCH v2] kobject: remove unused KOBJ_MAX action

[Greg KH]

On Wed, Jul 15, 2020 at 05:11:16PM +0200, Garrit Franke wrote:
> The loop in lib/kobject_uevent.c that checked for KOBJ_MAX is no longer present, we do
> a much more sane ARRAY_SIZE() check instead (see 5c5daf657cb5).

Odd line wrapping :(

When you specify a git commit, use the format as documented in the
submitting patches file:
	5c5daf657cb5 ("Driver core: exclude kobject_uevent.c for !CONFIG_HOTPLUG")

> Therefore, the KOBJ_MAX is not used anymore.

That sentence does not make much sense :(

thanks,

greg k-h

[PATCH v3] kobject: remove unused KOBJ_MAX action

[Garrit Franke]

The loop in libb/kobj_uevent.c that checked for KOBBJ_MAX is no longer
present, we do a much more sane ARRAY_SIZE() check instead. See
5c5daf657cb5 ("Driver core: exclude kobject_uevent.c for
!CONFIG_HOTPLUG").

Signed-off-by: Garrit Franke <garritfranke@gmail.com>
---
 include/linux/kobject.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index 6cba088bee24..ea30529fba08 100644
--- a/include/linux/kobject.h
+++ b/include/linux/kobject.h
@@ -59,7 +59,6 @@ enum kobject_action {
 	KOBJ_OFFLINE,
 	KOBJ_BIND,
 	KOBJ_UNBIND,
-	KOBJ_MAX
 };
 
 struct kobject {
-- 
2.25.1