* [PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE
@ 2020-07-16 9:06 Qinglang Miao
2020-07-19 1:59 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Qinglang Miao @ 2020-07-16 9:06 UTC (permalink / raw)
To: Greg Kroah-Hartman, Boris Ostrovsky, Juergen Gross, Chen-Yu Tsai,
Thomas Gleixner, Stefano Stabellini
Cc: xen-devel, linux-kernel
From: Chen Huang <chenhuang5@huawei.com>
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Chen Huang <chenhuang5@huawei.com>
---
arch/x86/xen/p2m.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 4cf680e2e..0f4a449de 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -799,17 +799,7 @@ static int p2m_dump_show(struct seq_file *m, void *v)
return 0;
}
-static int p2m_dump_open(struct inode *inode, struct file *filp)
-{
- return single_open(filp, p2m_dump_show, NULL);
-}
-
-static const struct file_operations p2m_dump_fops = {
- .open = p2m_dump_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(p2m_dump);
static struct dentry *d_mmu_debug;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE
2020-07-16 9:06 [PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
@ 2020-07-19 1:59 ` Boris Ostrovsky
2020-09-17 12:54 ` miaoqinglang
0 siblings, 1 reply; 3+ messages in thread
From: Boris Ostrovsky @ 2020-07-19 1:59 UTC (permalink / raw)
To: Qinglang Miao, Greg Kroah-Hartman, Juergen Gross, Chen-Yu Tsai,
Thomas Gleixner, Stefano Stabellini
Cc: xen-devel, linux-kernel
On 7/16/20 5:06 AM, Qinglang Miao wrote:
> From: Chen Huang <chenhuang5@huawei.com>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Chen Huang <chenhuang5@huawei.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE
2020-07-19 1:59 ` Boris Ostrovsky
@ 2020-09-17 12:54 ` miaoqinglang
0 siblings, 0 replies; 3+ messages in thread
From: miaoqinglang @ 2020-09-17 12:54 UTC (permalink / raw)
To: Boris Ostrovsky, Greg Kroah-Hartman, Juergen Gross, Chen-Yu Tsai,
Thomas Gleixner, Stefano Stabellini
Cc: xen-devel, linux-kernel
在 2020/7/19 9:59, Boris Ostrovsky 写道:
> On 7/16/20 5:06 AM, Qinglang Miao wrote:
>> From: Chen Huang <chenhuang5@huawei.com>
>>
>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>>
>> Signed-off-by: Chen Huang <chenhuang5@huawei.com>
>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
>
Hi Boris,
I noticed that this patch has been rebiewed but there's small conflict
if you apply it against latest linux-next. So I resend a v2 patch
against linux-next(20200917), and it can be applied to mainline cleanly
now.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-17 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 9:06 [PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
2020-07-19 1:59 ` Boris Ostrovsky
2020-09-17 12:54 ` miaoqinglang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).