* [PATCH] mfd: rn5t618: Fix caching of battery related registers
@ 2020-07-17 21:00 Andreas Kemnade
2020-07-22 9:56 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2020-07-17 21:00 UTC (permalink / raw)
To: lee.jones, linux-kernel, phh, stefan, b.galvani; +Cc: Andreas Kemnade
Battery status changes dynamically, so the corresponding registers
need to be considered volatile. Affected registers are:
- fuel gauge
- battery status
- battery interrupt
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/mfd/rn5t618.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index 232de50562f9..55c47e555dd8 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -44,6 +44,9 @@ static bool rn5t618_volatile_reg(struct device *dev, unsigned int reg)
case RN5T618_INTMON:
case RN5T618_RTC_CTRL1 ... RN5T618_RTC_CTRL2:
case RN5T618_RTC_SECONDS ... RN5T618_RTC_YEAR:
+ case RN5T618_CHGSTATE:
+ case RN5T618_CHGCTRL_IRR ... RN5T618_CHGERR_MONI:
+ case RN5T618_CONTROL ... RN5T618_CC_AVEREG0:
return true;
default:
return false;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: rn5t618: Fix caching of battery related registers
2020-07-17 21:00 [PATCH] mfd: rn5t618: Fix caching of battery related registers Andreas Kemnade
@ 2020-07-22 9:56 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-07-22 9:56 UTC (permalink / raw)
To: Andreas Kemnade; +Cc: linux-kernel, phh, stefan, b.galvani
On Fri, 17 Jul 2020, Andreas Kemnade wrote:
> Battery status changes dynamically, so the corresponding registers
> need to be considered volatile. Affected registers are:
> - fuel gauge
> - battery status
> - battery interrupt
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/mfd/rn5t618.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-22 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 21:00 [PATCH] mfd: rn5t618: Fix caching of battery related registers Andreas Kemnade
2020-07-22 9:56 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).