* [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host controller Seabird1
@ 2020-07-21 1:17 shirley her
[not found] ` <BY5PR16MB33196E3E0FB7C2143BE7D73F8B4D0@BY5PR16MB3319.namprd16.prod.outlook.com>
2020-08-05 6:34 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: shirley her @ 2020-07-21 1:17 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, linux-mmc, linux-kernel
Cc: shaper.liu, chevron.li, xiaoguang.yu, max.huang, shirley.her
Add bug fix for O2 host controller Seabird1
Signed-off-by: Shirley Her <shirley.her@bayhubtech.com>
---
change in V1:
1. Add quriks2 and mmc->caps2 for Seabird1
2. Add get_cd support for Seabird1
---
drivers/mmc/host/sdhci-pci-o2micro.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
index e2a846885902..ed3c605fcf0c 100644
--- a/drivers/mmc/host/sdhci-pci-o2micro.c
+++ b/drivers/mmc/host/sdhci-pci-o2micro.c
@@ -561,6 +561,12 @@ static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
}
+ if (chip->pdev->device == PCI_DEVICE_ID_O2_SEABIRD1) {
+ slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
+ host->mmc->caps2 |= MMC_CAP2_NO_SDIO;
+ host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;
+ }
+
host->mmc_host_ops.execute_tuning = sdhci_o2_execute_tuning;
if (chip->pdev->device != PCI_DEVICE_ID_O2_FUJIN2)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host controller Seabird1
[not found] ` <BY5PR16MB33196E3E0FB7C2143BE7D73F8B4D0@BY5PR16MB3319.namprd16.prod.outlook.com>
@ 2020-08-04 5:29 ` Adrian Hunter
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2020-08-04 5:29 UTC (permalink / raw)
To: Shirley Her (SC), ulf.hansson, linux-mmc, linux-kernel
Sorry, I have been away for a while, but I will look at it shortly.
On 3/08/20 10:23 pm, Shirley Her (SC) wrote:
> Hi, Adrian:
>
> Do you have chance to review the patched code?
>
> Thanks,
> Shirley
>
> ----------------------------------------------------------------------------
> *From:* Shirley Her (SC) <shirley.her@bayhubtech.com>
> *Sent:* Monday, July 20, 2020 6:18 PM
> *To:* adrian.hunter@intel.com <adrian.hunter@intel.com>;
> ulf.hansson@linaro.org <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org
> <linux-mmc@vger.kernel.org>; linux-kernel@vger.kernel.org
> <linux-kernel@vger.kernel.org>
> *Cc:* Shaper Liu (WH) <shaper.liu@bayhubtech.com>; Chevron Li (WH)
> <chevron.li@bayhubtech.com>; Xiaoguang Yu (WH)
> <xiaoguang.yu@bayhubtech.com>; Max Huang (SC) <max.huang@bayhubtech.com>;
> Shirley Her (SC) <shirley.her@bayhubtech.com>
> *Subject:* [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host
> controller Seabird1
>
> Add bug fix for O2 host controller Seabird1
>
> Signed-off-by: Shirley Her <shirley.her@bayhubtech.com>
> ---
> change in V1:
> 1. Add quriks2 and mmc->caps2 for Seabird1
> 2. Add get_cd support for Seabird1
> ---
> drivers/mmc/host/sdhci-pci-o2micro.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c
> b/drivers/mmc/host/sdhci-pci-o2micro.c
> index e2a846885902..ed3c605fcf0c 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -561,6 +561,12 @@ static int sdhci_pci_o2_probe_slot(struct
> sdhci_pci_slot *slot)
> slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
> }
>
> + if (chip->pdev->device == PCI_DEVICE_ID_O2_SEABIRD1) {
> + slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
> + host->mmc->caps2 |= MMC_CAP2_NO_SDIO;
> + host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;
> + }
> +
> host->mmc_host_ops.execute_tuning = sdhci_o2_execute_tuning;
>
> if (chip->pdev->device != PCI_DEVICE_ID_O2_FUJIN2)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host controller Seabird1
2020-07-21 1:17 [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host controller Seabird1 shirley her
[not found] ` <BY5PR16MB33196E3E0FB7C2143BE7D73F8B4D0@BY5PR16MB3319.namprd16.prod.outlook.com>
@ 2020-08-05 6:34 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-08-05 6:34 UTC (permalink / raw)
To: shirley her
Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List,
Shaper Liu (WH), Chevron Li (WH), Xiaoguang Yu (WH),
Max Huang (SC)
On Tue, 21 Jul 2020 at 03:18, shirley her <shirley.her@bayhubtech.com> wrote:
>
> Add bug fix for O2 host controller Seabird1
>
> Signed-off-by: Shirley Her <shirley.her@bayhubtech.com>
Applied for next (a while ago), thanks!
> ---
> change in V1:
> 1. Add quriks2 and mmc->caps2 for Seabird1
> 2. Add get_cd support for Seabird1
Future wise, I wouldn't mind that you fold some of this information
into the commit message. It's always good to have a good description
of the change.
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-pci-o2micro.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index e2a846885902..ed3c605fcf0c 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -561,6 +561,12 @@ static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
> }
>
> + if (chip->pdev->device == PCI_DEVICE_ID_O2_SEABIRD1) {
> + slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
> + host->mmc->caps2 |= MMC_CAP2_NO_SDIO;
> + host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;
> + }
> +
> host->mmc_host_ops.execute_tuning = sdhci_o2_execute_tuning;
>
> if (chip->pdev->device != PCI_DEVICE_ID_O2_FUJIN2)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-05 6:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 1:17 [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host controller Seabird1 shirley her
[not found] ` <BY5PR16MB33196E3E0FB7C2143BE7D73F8B4D0@BY5PR16MB3319.namprd16.prod.outlook.com>
2020-08-04 5:29 ` Adrian Hunter
2020-08-05 6:34 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).