From: Greg KH <gregkh@linuxfoundation.org>
To: Qiwu Huang <yanziily@gmail.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com,
Qiwu Huang <huangqiwu@xiaomi.com>
Subject: Re: [PATCH v5 4/4] power: supply: core: property to control reverse charge
Date: Tue, 21 Jul 2020 10:21:28 +0200 [thread overview]
Message-ID: <20200721082128.GE1655283@kroah.com> (raw)
In-Reply-To: <f58e4cc6f5235d463d96c950f2af2b9a47920e9d.1595301250.git.huangqiwu@xiaomi.com>
On Tue, Jul 21, 2020 at 01:59:37PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
>
> Interface to control wireless reverse charge.
> Supply reverse charge function when enabled.
>
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
> Documentation/ABI/testing/sysfs-class-power | 12 ++++++++++++
> drivers/power/supply/power_supply_sysfs.c | 1 +
> include/linux/power_supply.h | 1 +
> 3 files changed, 14 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 75ec7de2fe78..54647d6995d3 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -767,3 +767,15 @@ Description:
>
> Access: Read-Only
> Valid values: 0 - 100
> +
> +What: /sys/class/power_supply/<supply_name>/reverse_chg_mode
> +Date: Jul 2020
> +Contact: Fei Jiang <jiangfei1@xiaomi.com>
> +Description:
> + Some phones support wireless reverse charge function which charge other phones.
Replace "phones" with "devices"?
And shouldn't these lines be wrapped properly at 72 colums or so?
> + The property supply interface to control wireless reverse charge.
I can't understand this sentance.
> + If enabled, start TX mode and detect RX. Disabled when timeout or manual setting.
Can this be set, or is it just something to be read?
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-21 8:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 5:59 [PATCH v5 0/4] add some power supply properties about wireless/wired charging Qiwu Huang
2020-07-21 5:59 ` [PATCH v5 1/4] power: supply: core: add quick charge type property Qiwu Huang
2020-07-21 8:18 ` Greg KH
2020-07-21 5:59 ` [PATCH v5 2/4] power: supply: core: add wireless charger adapter " Qiwu Huang
2020-07-21 8:19 ` Greg KH
2020-07-21 5:59 ` [PATCH v5 3/4] power: supply: core: add wireless signal strength property Qiwu Huang
2020-07-21 8:20 ` Greg KH
2020-07-21 10:21 ` ivan
2020-07-21 10:32 ` Greg KH
2020-07-21 10:34 ` ivan
2020-07-21 5:59 ` [PATCH v5 4/4] power: supply: core: property to control reverse charge Qiwu Huang
2020-07-21 8:21 ` Greg KH [this message]
2020-07-21 10:40 ` ivan
2020-07-21 8:21 ` [PATCH v5 0/4] add some power supply properties about wireless/wired charging Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721082128.GE1655283@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=huangqiwu@xiaomi.com \
--cc=jiangfei1@xiaomi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=yanziily@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).