Re: [PATCH v5 3/4] power: supply: core: add wireless signal strength property

[ivan <yanziily@gmail.com>]

On Tue, Jul 21, 2020 at 6:32 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jul 21, 2020 at 06:21:20PM +0800, ivan wrote:
> > On Tue, Jul 21, 2020 at 4:19 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Tue, Jul 21, 2020 at 01:59:36PM +0800, Qiwu Huang wrote:
> > > > From: Qiwu Huang <huangqiwu@xiaomi.com>
> > > >
> > > > reports wireless signal strength.
> > > > The value show degree of coupling between tx and rx.
> > > >
> > > > Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> > > > ---
> > > >  Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++
> > > >  drivers/power/supply/power_supply_sysfs.c   |  1 +
> > > >  include/linux/power_supply.h                |  1 +
> > > >  3 files changed, 12 insertions(+)
> > > >
> > > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > > > index 03ab449fae8a..75ec7de2fe78 100644
> > > > --- a/Documentation/ABI/testing/sysfs-class-power
> > > > +++ b/Documentation/ABI/testing/sysfs-class-power
> > > > @@ -757,3 +757,13 @@ Description:
> > > >                       13: ADAPTER_VOICE_BOX,
> > > >                       14: ADAPTER_PRIVATE_PD_50W.
> > > >
> > > > +What:                /sys/class/power_supply/<supply_name>/signal_strength
> > > > +Date:                Jul 2020
> > > > +Contact:     Fei Jiang <jiangfei1@xiaomi.com>
> > > > +Description:
> > > > +             In PING phase, RX transmits a signal strength packet as the first
> > >
> > > What does "PING phase" mean?
> >
> > The Qi Wireless Power Transfer System is published by the Wireless
> > Power Consortium.
> > The ping phase is the necessary stage for matching transmitter and
> > receiver. In this phase,
> > the Power Transmitter executes a Digital Ping, and listens for a
> > response. If the
> > Power Transmitter discovers a Power Receiver, the Power Transmitter
> > may extend the Digital Ping,
> > i.e. maintain the Power Signal at the level of the Digital Ping. This
> > causes the system to proceed to the
> > identification & configuration phase. If the Power Transmitter does
> > not extend the Digital Ping, the
> > system shall revert to the selection phase.
>
> Thanks for the description, so perhaps turning this response into the
> text in the description would be good?

OK， I will

>
> thanks,
>
> greg k-h



-- 
Thanks

Qiwu