* [PATCH] xtensa: fix closing endif comment
@ 2020-07-21 2:47 Max Filippov
2020-07-21 10:24 ` Mike Rapoport
2020-07-28 2:38 ` Max Filippov
0 siblings, 2 replies; 3+ messages in thread
From: Max Filippov @ 2020-07-21 2:47 UTC (permalink / raw)
To: linux-xtensa; +Cc: Chris Zankel, linux-kernel, Max Filippov, Mike Rapoport
Commit 8f74afa22d9b ("xtensa: switch to generic version of pte
allocation") introduced the following build warning for xtensa
arch/xtensa/include/asm/pgalloc.h:67:8: warning: extra tokens at end of
#endif directive [-Wendif-labels]
Fix #endif comment.
Cc: Mike Rapoport <rppt@linux.ibm.com>
Fixes: 8f74afa22d9b ("xtensa: switch to generic version of pte allocation")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
arch/xtensa/include/asm/pgalloc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h
index 699a8fdf9005..d3a22da4d2c9 100644
--- a/arch/xtensa/include/asm/pgalloc.h
+++ b/arch/xtensa/include/asm/pgalloc.h
@@ -64,6 +64,6 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
}
#define pmd_pgtable(pmd) pmd_page(pmd)
-#endif CONFIG_MMU
+#endif /* CONFIG_MMU */
#endif /* _XTENSA_PGALLOC_H */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xtensa: fix closing endif comment
2020-07-21 2:47 [PATCH] xtensa: fix closing endif comment Max Filippov
@ 2020-07-21 10:24 ` Mike Rapoport
2020-07-28 2:38 ` Max Filippov
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2020-07-21 10:24 UTC (permalink / raw)
To: Max Filippov; +Cc: linux-xtensa, Chris Zankel, linux-kernel
On Mon, Jul 20, 2020 at 07:47:51PM -0700, Max Filippov wrote:
> Commit 8f74afa22d9b ("xtensa: switch to generic version of pte
> allocation") introduced the following build warning for xtensa
> arch/xtensa/include/asm/pgalloc.h:67:8: warning: extra tokens at end of
> #endif directive [-Wendif-labels]
> Fix #endif comment.
Oops :)
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Fixes: 8f74afa22d9b ("xtensa: switch to generic version of pte allocation")
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/xtensa/include/asm/pgalloc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h
> index 699a8fdf9005..d3a22da4d2c9 100644
> --- a/arch/xtensa/include/asm/pgalloc.h
> +++ b/arch/xtensa/include/asm/pgalloc.h
> @@ -64,6 +64,6 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
> }
>
> #define pmd_pgtable(pmd) pmd_page(pmd)
> -#endif CONFIG_MMU
> +#endif /* CONFIG_MMU */
>
> #endif /* _XTENSA_PGALLOC_H */
> --
> 2.20.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] xtensa: fix closing endif comment
2020-07-21 2:47 [PATCH] xtensa: fix closing endif comment Max Filippov
2020-07-21 10:24 ` Mike Rapoport
@ 2020-07-28 2:38 ` Max Filippov
1 sibling, 0 replies; 3+ messages in thread
From: Max Filippov @ 2020-07-28 2:38 UTC (permalink / raw)
To: linux-xtensa
Cc: Chris Zankel, linux-kernel, Andrew Morton, Max Filippov, Mike Rapoport
Commit 8f74afa22d9b ("xtensa: switch to generic version of pte
allocation") introduced the following build warning for xtensa
arch/xtensa/include/asm/pgalloc.h:67:8: warning: extra tokens at end of
#endif directive [-Wendif-labels]
Fix #endif comment.
Cc: Mike Rapoport <rppt@linux.ibm.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Fixes: 8f74afa22d9b ("xtensa: switch to generic version of pte allocation")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
Andrew, could you please take this patch as the change that it fixes is
currently in the mm tree?
arch/xtensa/include/asm/pgalloc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h
index 699a8fdf9005..d3a22da4d2c9 100644
--- a/arch/xtensa/include/asm/pgalloc.h
+++ b/arch/xtensa/include/asm/pgalloc.h
@@ -64,6 +64,6 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
}
#define pmd_pgtable(pmd) pmd_page(pmd)
-#endif CONFIG_MMU
+#endif /* CONFIG_MMU */
#endif /* _XTENSA_PGALLOC_H */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-28 2:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 2:47 [PATCH] xtensa: fix closing endif comment Max Filippov
2020-07-21 10:24 ` Mike Rapoport
2020-07-28 2:38 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).