From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Gautham R Shenoy <ego@linux.vnet.ibm.com>
Cc: Michael Ellerman <michaele@au1.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Nick Piggin <npiggin@au1.ibm.com>,
Oliver OHalloran <oliveroh@au1.ibm.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
Michael Neuling <mikey@linux.ibm.com>,
Anton Blanchard <anton@au1.ibm.com>,
Vaidyanathan Srinivasan <svaidy@linux.ibm.com>,
Jordan Niethe <jniethe5@gmail.com>
Subject: Re: [PATCH v2 04/10] powerpc/smp: Enable small core scheduling sooner
Date: Wed, 22 Jul 2020 12:29:07 +0530 [thread overview]
Message-ID: <20200722065907.GC9290@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200722055925.GC31038@in.ibm.com>
* Gautham R Shenoy <ego@linux.vnet.ibm.com> [2020-07-22 11:29:25]:
> Hello Srikar,
>
> On Tue, Jul 21, 2020 at 05:08:08PM +0530, Srikar Dronamraju wrote:
> > Enable small core scheduling as soon as we detect that we are in a
> > system that supports thread group. Doing so would avoid a redundant
> > check.
>
> The patch looks good to me. However, I think the commit message still
> reflect the v1 code where we were moving the functionality from
> smp_cpus_done() to init_big_cores().
>
> In this we are moving it to a helper function to collate all fixups to
> topology.
>
Right.
Thanks for pointing , will correct this.
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-07-22 6:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 11:38 [PATCH v2 00/10] Coregroup support on Powerpc Srikar Dronamraju
2020-07-21 11:38 ` [PATCH v2 01/10] powerpc/smp: Cache node for reuse Srikar Dronamraju
2020-07-22 7:41 ` Michael Ellerman
2020-07-22 8:04 ` Srikar Dronamraju
2020-07-21 11:38 ` [PATCH v2 02/10] powerpc/smp: Merge Power9 topology with Power topology Srikar Dronamraju
2020-07-22 5:48 ` Gautham R Shenoy
2020-07-21 11:38 ` [PATCH v2 03/10] powerpc/smp: Move powerpc_topology above Srikar Dronamraju
2020-07-21 11:38 ` [PATCH v2 04/10] powerpc/smp: Enable small core scheduling sooner Srikar Dronamraju
2020-07-22 5:59 ` Gautham R Shenoy
2020-07-22 6:59 ` Srikar Dronamraju [this message]
2020-07-21 11:38 ` [PATCH v2 05/10] powerpc/smp: Dont assume l2-cache to be superset of sibling Srikar Dronamraju
2020-07-22 6:21 ` Gautham R Shenoy
2020-07-22 6:57 ` Srikar Dronamraju
2020-07-24 7:10 ` Gautham R Shenoy
2020-07-21 11:38 ` [PATCH v2 06/10] powerpc/smp: Generalize 2nd sched domain Srikar Dronamraju
2020-07-22 6:56 ` Gautham R Shenoy
2020-07-22 7:39 ` Srikar Dronamraju
2020-07-22 7:46 ` peterz
2020-07-22 8:18 ` Srikar Dronamraju
2020-07-22 8:48 ` Peter Zijlstra
2020-07-22 8:54 ` peterz
2020-07-21 11:38 ` [PATCH v2 07/10] Powerpc/numa: Detect support for coregroup Srikar Dronamraju
2020-07-21 11:38 ` [PATCH v2 08/10] powerpc/smp: Allocate cpumask only after searching thread group Srikar Dronamraju
2020-07-21 11:38 ` [PATCH v2 09/10] Powerpc/smp: Create coregroup domain Srikar Dronamraju
2020-07-22 7:04 ` Gautham R Shenoy
2020-07-22 7:29 ` Srikar Dronamraju
2020-07-21 11:38 ` [PATCH v2 10/10] powerpc/smp: Implement cpu_to_coregroup_id Srikar Dronamraju
2020-07-22 7:06 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722065907.GC9290@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=anton@au1.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=jniethe5@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mikey@linux.ibm.com \
--cc=mingo@kernel.org \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@au1.ibm.com \
--cc=oliveroh@au1.ibm.com \
--cc=peterz@infradead.org \
--cc=svaidy@linux.ibm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).