* [PATCH] ceph: remove redundant initialization of variable mds
@ 2020-07-23 15:22 Colin King
2020-07-23 17:24 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-07-23 15:22 UTC (permalink / raw)
To: Jeff Layton, Ilya Dryomov, ceph-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable mds is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ceph/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
index 070ed8481340..48f5afb56c91 100644
--- a/fs/ceph/debugfs.c
+++ b/fs/ceph/debugfs.c
@@ -272,7 +272,7 @@ static int mds_sessions_show(struct seq_file *s, void *ptr)
struct ceph_mds_client *mdsc = fsc->mdsc;
struct ceph_auth_client *ac = fsc->client->monc.auth;
struct ceph_options *opt = fsc->client->options;
- int mds = -1;
+ int mds;
mutex_lock(&mdsc->mutex);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ceph: remove redundant initialization of variable mds
2020-07-23 15:22 [PATCH] ceph: remove redundant initialization of variable mds Colin King
@ 2020-07-23 17:24 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2020-07-23 17:24 UTC (permalink / raw)
To: Colin King, Ilya Dryomov, ceph-devel; +Cc: kernel-janitors, linux-kernel
On Thu, 2020-07-23 at 16:22 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable mds is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ceph/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 070ed8481340..48f5afb56c91 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -272,7 +272,7 @@ static int mds_sessions_show(struct seq_file *s, void *ptr)
> struct ceph_mds_client *mdsc = fsc->mdsc;
> struct ceph_auth_client *ac = fsc->client->monc.auth;
> struct ceph_options *opt = fsc->client->options;
> - int mds = -1;
> + int mds;
>
> mutex_lock(&mdsc->mutex);
>
Thanks, merged into testing branch.
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-23 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 15:22 [PATCH] ceph: remove redundant initialization of variable mds Colin King
2020-07-23 17:24 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).