linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig
@ 2020-07-23 17:11 Sedat Dilek
  2020-07-23 17:29 ` Randy Dunlap
  2020-07-24 13:10 ` [tip: x86/build] x86/defconfigs: " tip-bot2 for Sedat Dilek
  0 siblings, 2 replies; 4+ messages in thread
From: Sedat Dilek @ 2020-07-23 17:11 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
	H. Peter Anvin, Diego Elio Pettenò,
	Randy Dunlap, Maciej W. Rozycki, Martin K. Petersen,
	Masahiro Yamada, Sedat Dilek, linux-kernel
  Cc: Ard Biesheuvel, Herbert Xu

Initially CONFIG_CRYPTO_AES_586=y was added to i386_defconfig file
with commit c1b362e3b4d3 ("x86: update defconfigs").

The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:

commit 1d2c3279311e4f03fcf164e1366f2fda9f4bfccf
("crypto: x86/aes - drop scalar assembler implementations")

Remove the Kconfig relict from i386_defconfig file.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
Changes v1 -> v2:
- Add CC to Ard and Herbert (see commit 1d2c3279311e)

 arch/x86/configs/i386_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 550904591e94..3a2a89882350 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
 CONFIG_SECURITY_SELINUX=y
 CONFIG_SECURITY_SELINUX_BOOTPARAM=y
 CONFIG_SECURITY_SELINUX_DISABLE=y
-CONFIG_CRYPTO_AES_586=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_EFI_STUB=y
 CONFIG_ACPI_BGRT=y
-- 
2.28.0.rc2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig
  2020-07-23 17:11 [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig Sedat Dilek
@ 2020-07-23 17:29 ` Randy Dunlap
  2020-07-23 17:51   ` Sedat Dilek
  2020-07-24 13:10 ` [tip: x86/build] x86/defconfigs: " tip-bot2 for Sedat Dilek
  1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-07-23 17:29 UTC (permalink / raw)
  To: Sedat Dilek, Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
	H. Peter Anvin, Diego Elio Pettenò,
	Maciej W. Rozycki, Martin K. Petersen, Masahiro Yamada,
	linux-kernel
  Cc: Ard Biesheuvel, Herbert Xu

On 7/23/20 10:11 AM, Sedat Dilek wrote:
> Initially CONFIG_CRYPTO_AES_586=y was added to i386_defconfig file
> with commit c1b362e3b4d3 ("x86: update defconfigs").
> 
> The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:
> 
> commit 1d2c3279311e4f03fcf164e1366f2fda9f4bfccf
> ("crypto: x86/aes - drop scalar assembler implementations")
> 
> Remove the Kconfig relict from i386_defconfig file.

                     relic

> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> Changes v1 -> v2:
> - Add CC to Ard and Herbert (see commit 1d2c3279311e)
> 
>  arch/x86/configs/i386_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
> index 550904591e94..3a2a89882350 100644
> --- a/arch/x86/configs/i386_defconfig
> +++ b/arch/x86/configs/i386_defconfig
> @@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
>  CONFIG_SECURITY_SELINUX=y
>  CONFIG_SECURITY_SELINUX_BOOTPARAM=y
>  CONFIG_SECURITY_SELINUX_DISABLE=y
> -CONFIG_CRYPTO_AES_586=y
>  # CONFIG_CRYPTO_ANSI_CPRNG is not set
>  CONFIG_EFI_STUB=y
>  CONFIG_ACPI_BGRT=y
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig
  2020-07-23 17:29 ` Randy Dunlap
@ 2020-07-23 17:51   ` Sedat Dilek
  0 siblings, 0 replies; 4+ messages in thread
From: Sedat Dilek @ 2020-07-23 17:51 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
	H. Peter Anvin, Diego Elio Pettenò,
	Maciej W. Rozycki, Martin K. Petersen, Masahiro Yamada,
	linux-kernel, Ard Biesheuvel, Herbert Xu

On Thu, Jul 23, 2020 at 7:29 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 7/23/20 10:11 AM, Sedat Dilek wrote:
> > Initially CONFIG_CRYPTO_AES_586=y was added to i386_defconfig file
> > with commit c1b362e3b4d3 ("x86: update defconfigs").
> >
> > The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:
> >
> > commit 1d2c3279311e4f03fcf164e1366f2fda9f4bfccf
> > ("crypto: x86/aes - drop scalar assembler implementations")
> >
> > Remove the Kconfig relict from i386_defconfig file.
>
>                      relic
>

leftover :-)

https://dict.leo.org/englisch-deutsch/Relikt

> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>

Thanks for the review.

- Sedat -

> Thanks.
>
> > ---
> > Changes v1 -> v2:
> > - Add CC to Ard and Herbert (see commit 1d2c3279311e)
> >
> >  arch/x86/configs/i386_defconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
> > index 550904591e94..3a2a89882350 100644
> > --- a/arch/x86/configs/i386_defconfig
> > +++ b/arch/x86/configs/i386_defconfig
> > @@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
> >  CONFIG_SECURITY_SELINUX=y
> >  CONFIG_SECURITY_SELINUX_BOOTPARAM=y
> >  CONFIG_SECURITY_SELINUX_DISABLE=y
> > -CONFIG_CRYPTO_AES_586=y
> >  # CONFIG_CRYPTO_ANSI_CPRNG is not set
> >  CONFIG_EFI_STUB=y
> >  CONFIG_ACPI_BGRT=y
> >
>
>
> --
> ~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [tip: x86/build] x86/defconfigs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig
  2020-07-23 17:11 [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig Sedat Dilek
  2020-07-23 17:29 ` Randy Dunlap
@ 2020-07-24 13:10 ` tip-bot2 for Sedat Dilek
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Sedat Dilek @ 2020-07-24 13:10 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Sedat Dilek, Ingo Molnar, Randy Dunlap, x86, LKML

The following commit has been merged into the x86/build branch of tip:

Commit-ID:     6526b12de07588253a52577f42ec99fc7ca26a1f
Gitweb:        https://git.kernel.org/tip/6526b12de07588253a52577f42ec99fc7ca26a1f
Author:        Sedat Dilek <sedat.dilek@gmail.com>
AuthorDate:    Thu, 23 Jul 2020 19:11:14 +02:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Fri, 24 Jul 2020 14:55:55 +02:00

x86/defconfigs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig

Initially CONFIG_CRYPTO_AES_586=y was added to the i386_defconfig file in:

  c1b362e3b4d3: ("x86: update defconfigs")

The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:

  1d2c3279311e: ("crypto: x86/aes - drop scalar assembler implementations")

Remove the leftover from the i386_defconfig file as well.

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20200723171119.9881-1-sedat.dilek@gmail.com
---
 arch/x86/configs/i386_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 5509045..3a2a898 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
 CONFIG_SECURITY_SELINUX=y
 CONFIG_SECURITY_SELINUX_BOOTPARAM=y
 CONFIG_SECURITY_SELINUX_DISABLE=y
-CONFIG_CRYPTO_AES_586=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_EFI_STUB=y
 CONFIG_ACPI_BGRT=y

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-24 13:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 17:11 [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig Sedat Dilek
2020-07-23 17:29 ` Randy Dunlap
2020-07-23 17:51   ` Sedat Dilek
2020-07-24 13:10 ` [tip: x86/build] x86/defconfigs: " tip-bot2 for Sedat Dilek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).