From: Joel Stanley <joel@jms.id.au>
To: linux-fsi@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joachim Fenkes <FENKES@de.ibm.com>,
linux-kernel@vger.kernel.org, Jeremy Kerr <jk@ozlabs.org>,
Alistar Popple <alistair@popple.id.au>,
Eddie James <eajames@linux.ibm.com>
Subject: [PATCH 1/2] fsi/sbefifo: Clean up correct FIFO when receiving reset request from SBE
Date: Fri, 24 Jul 2020 16:45:17 +0930 [thread overview]
Message-ID: <20200724071518.430515-2-joel@jms.id.au> (raw)
In-Reply-To: <20200724071518.430515-1-joel@jms.id.au>
From: Joachim Fenkes <FENKES@de.ibm.com>
When the SBE requests a reset via the down FIFO, that is also the
FIFO we should go and reset ;)
Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Signed-off-by: Joachim Fenkes <FENKES@de.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
drivers/fsi/fsi-sbefifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index f54df9ebc8b3..655b45c1f6ba 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -400,7 +400,7 @@ static int sbefifo_cleanup_hw(struct sbefifo *sbefifo)
/* The FIFO already contains a reset request from the SBE ? */
if (down_status & SBEFIFO_STS_RESET_REQ) {
dev_info(dev, "Cleanup: FIFO reset request set, resetting\n");
- rc = sbefifo_regw(sbefifo, SBEFIFO_UP, SBEFIFO_PERFORM_RESET);
+ rc = sbefifo_regw(sbefifo, SBEFIFO_DOWN, SBEFIFO_PERFORM_RESET);
if (rc) {
sbefifo->broken = true;
dev_err(dev, "Cleanup: Reset reg write failed, rc=%d\n", rc);
--
2.27.0
next prev parent reply other threads:[~2020-07-24 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 7:15 [PATCH 0/2] fsi: SBE FIFO fixes Joel Stanley
2020-07-24 7:15 ` Joel Stanley [this message]
2020-07-27 5:51 ` [PATCH 1/2] fsi/sbefifo: Clean up correct FIFO when receiving reset request from SBE Benjamin Herrenschmidt
2020-09-10 3:08 ` Joel Stanley
2020-07-24 7:15 ` [PATCH 2/2] fsi/sbefifo: Fix reset timeout Joel Stanley
2020-07-24 14:34 ` Guenter Roeck
2020-09-10 3:08 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724071518.430515-2-joel@jms.id.au \
--to=joel@jms.id.au \
--cc=FENKES@de.ibm.com \
--cc=alistair@popple.id.au \
--cc=benh@kernel.crashing.org \
--cc=eajames@linux.ibm.com \
--cc=jk@ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).