* [PATCH] Fix one coding style issue
@ 2020-07-25 10:30 Anant Thazhemadam
2020-07-25 11:05 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Anant Thazhemadam @ 2020-07-25 10:30 UTC (permalink / raw)
Cc: anant.thazhemadam, Larry Finger, Greg Kroah-Hartman, Joe Perches,
Rahul Gottipati, Merwin Trever Ferrao, Michael Straube, devel,
linux-kernel
The coding style issue that raised an error (upon checking against
checkpatch.pl) has been fixed.
Exactly one coding style issue has been fixed; as required by Task 10
of the Eudyptula Challenge.
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_security.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
index 21f6652dd69f..dc22ee9c24ad 100644
--- a/drivers/staging/rtl8188eu/core/rtw_security.c
+++ b/drivers/staging/rtl8188eu/core/rtw_security.c
@@ -718,7 +718,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
res = _FAIL;
}
} else {
- RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
+ RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
+ ("%s: stainfo==NULL!!!\n", __func__)
+ );
res = _FAIL;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix one coding style issue
2020-07-25 10:30 [PATCH] Fix one coding style issue Anant Thazhemadam
@ 2020-07-25 11:05 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-25 11:05 UTC (permalink / raw)
To: Anant Thazhemadam
Cc: Merwin Trever Ferrao, devel, linux-kernel, Joe Perches, Larry Finger
On Sat, Jul 25, 2020 at 04:00:03PM +0530, Anant Thazhemadam wrote:
> The coding style issue that raised an error (upon checking against
> checkpatch.pl) has been fixed.
You are not saying what issue was fixed.
Also, your subject line needs to be fixed, please see the link provided
by the bot previously for what to do.
> Exactly one coding style issue has been fixed; as required by Task 10
> of the Eudyptula Challenge.
We don't care why you are doing this work, no need to put that in the
changelog.
>
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index 21f6652dd69f..dc22ee9c24ad 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -718,7 +718,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
> res = _FAIL;
> }
> } else {
> - RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
> + RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> + ("%s: stainfo==NULL!!!\n", __func__)
> + );
Very odd line breaks, this now looks worse than before :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25 10:30 [PATCH] Fix one coding style issue Anant Thazhemadam
2020-07-25 11:05 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).