From: Christoph Hellwig <hch@lst.de>
To: Jessica Yu <jeyu@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE
Date: Fri, 31 Jul 2020 11:00:08 +0200 [thread overview]
Message-ID: <20200731090008.GA12930@lst.de> (raw)
In-Reply-To: <20200731085129.GA20130@linux-8ccs>
On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote:
>> + if (mod->using_gplonly_symbols) {
>> + pr_info("%s: module using GPL-only symbols uses symbols from proprietary module %s.\n",
>> + mod->name, owner->name);
>
> pr_err() maybe?
>
>> + return false;
>> + }
>> +
>> + if (!test_bit(TAINT_PROPRIETARY_MODULE, &mod->taints)) {
>> + pr_info("%s: module uses symbols from proprietary module %s, inheriting taint.\n",
>> + mod->name, owner->name);
>
> and pr_warn()? But otherwise this looks much better.
Ok with me. Can you just fix it up, or do you want a full resend?
next prev parent reply other threads:[~2020-07-31 9:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 6:10 inherit TAINT_PROPRIETARY_MODULE v2 Christoph Hellwig
2020-07-30 6:10 ` [PATCH 1/8] modules: mark ref_module static Christoph Hellwig
2020-07-30 6:10 ` [PATCH 2/8] modules: mark find_symbol static Christoph Hellwig
2020-07-30 6:10 ` [PATCH 3/8] modules: mark each_symbol_section static Christoph Hellwig
2020-07-30 6:10 ` [PATCH 4/8] modules: unexport __module_text_address Christoph Hellwig
2020-07-30 6:10 ` [PATCH 5/8] modules: unexport __module_address Christoph Hellwig
2020-07-30 6:10 ` [PATCH 6/8] modules: rename the licence field in struct symsearch to license Christoph Hellwig
2020-07-30 6:10 ` [PATCH 7/8] modules: return licensing information from find_symbol Christoph Hellwig
2020-07-30 6:10 ` [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE Christoph Hellwig
2020-07-30 14:12 ` Jessica Yu
2020-07-30 16:29 ` Christoph Hellwig
2020-07-31 8:51 ` Jessica Yu
2020-07-31 9:00 ` Christoph Hellwig [this message]
2020-07-31 9:01 ` Jessica Yu
2020-08-04 18:52 ` daniel
2020-07-31 20:11 ` inherit TAINT_PROPRIETARY_MODULE v2 josh
2020-08-01 6:53 ` Christoph Hellwig
2020-08-01 8:16 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731090008.GA12930@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).