* [PATCH] scsi: qla2xxx: Remove redundant variable initialization
@ 2020-08-02 11:15 Tianjia Zhang
2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Tianjia Zhang @ 2020-08-02 11:15 UTC (permalink / raw)
To: njavali, jejb, martin.petersen, quinn.tran, himanshu.madhani
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, tianjia.zhang
The initialization value of `rc` is wrong. It is unnecessary to
initialize `rc` variables, so remove its initialization operation.
Fixes: 84905dfe78d28 ("scsi: qla2xxx: Fix TMF and Multi-Queue config")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index fbb80a043b4f..c2c0e6049da4 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -2025,7 +2025,7 @@ static void qlt_do_tmr_work(struct work_struct *work)
struct qla_tgt_mgmt_cmd *mcmd =
container_of(work, struct qla_tgt_mgmt_cmd, work);
struct qla_hw_data *ha = mcmd->vha->hw;
- int rc = EIO;
+ int rc;
uint32_t tag;
unsigned long flags;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Remove redundant variable initialization
2020-08-02 11:15 [PATCH] scsi: qla2xxx: Remove redundant variable initialization Tianjia Zhang
@ 2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-08-31 17:41 UTC (permalink / raw)
To: jejb, himanshu.madhani, njavali, quinn.tran, Tianjia Zhang
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, linux-scsi,
tianjia.zhang, linux-kernel
On Sun, 2 Aug 2020 19:15:27 +0800, Tianjia Zhang wrote:
> The initialization value of `rc` is wrong. It is unnecessary to
> initialize `rc` variables, so remove its initialization operation.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Remove redundant variable initialization
https://git.kernel.org/mkp/scsi/c/8905cbdae986
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-31 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 11:15 [PATCH] scsi: qla2xxx: Remove redundant variable initialization Tianjia Zhang
2020-08-31 17:41 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).