* [PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()
@ 2020-08-02 11:15 Tianjia Zhang
2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Tianjia Zhang @ 2020-08-02 11:15 UTC (permalink / raw)
To: njavali, jejb, martin.petersen, himanshu.madhani, quinn.tran
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, tianjia.zhang
In the case of a failed retry, a positive value EIO is returned here.
I think this is a typo error. It is necessary to return an error value.
Fixes: 0691094ff3f2c ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index c2c0e6049da4..f2bb841c2059 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha,
/* found existing exchange */
qpair->retry_term_cnt++;
if (qpair->retry_term_cnt >= 5) {
- rc = EIO;
+ rc = -EIO;
qpair->retry_term_cnt = 0;
ql_log(ql_log_warn, vha, 0xffff,
"Unable to send ABTS Respond. Dumping firmware.\n");
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()
2020-08-02 11:15 [PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg() Tianjia Zhang
@ 2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-08-31 17:41 UTC (permalink / raw)
To: jejb, himanshu.madhani, njavali, quinn.tran, Tianjia Zhang
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, linux-scsi,
tianjia.zhang, linux-kernel
On Sun, 2 Aug 2020 19:15:28 +0800, Tianjia Zhang wrote:
> In the case of a failed retry, a positive value EIO is returned here.
> I think this is a typo error. It is necessary to return an error value.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()
https://git.kernel.org/mkp/scsi/c/bbf2d06a9d76
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-31 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 11:15 [PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg() Tianjia Zhang
2020-08-31 17:41 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).