* [PATCH] Modify the parameters that are not used
@ 2020-08-02 3:44 leesagacious
2020-08-02 6:59 ` kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: leesagacious @ 2020-08-02 3:44 UTC (permalink / raw)
To: linux-kernel; +Cc: leesagacious
Signed-off-by: leesagacious <lizhe@cpu-os.ac.cn>
---
include/linux/bottom_half.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/bottom_half.h b/include/linux/bottom_half.h
index a19519f..ab54f34 100644
--- a/include/linux/bottom_half.h
+++ b/include/linux/bottom_half.h
@@ -7,7 +7,8 @@
#ifdef CONFIG_TRACE_IRQFLAGS
extern void __local_bh_disable_ip(unsigned long ip, unsigned int cnt);
#else
-static __always_inline void __local_bh_disable_ip(unsigned long ip, unsigned int cnt)
+static __always_inline void __local_bh_disable_ip(unsigned long __unused ip,
+ unsigned int cnt)
{
preempt_count_add(cnt);
barrier();
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Modify the parameters that are not used
2020-08-02 3:44 [PATCH] Modify the parameters that are not used leesagacious
@ 2020-08-02 6:59 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-08-02 6:59 UTC (permalink / raw)
To: leesagacious, linux-kernel; +Cc: kbuild-all, leesagacious
[-- Attachment #1: Type: text/plain, Size: 3272 bytes --]
Hi leesagacious,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.8-rc7 next-20200731]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/leesagacious/Modify-the-parameters-that-are-not-used/20200802-115945
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 6ba1b005ffc388c2aeaddae20da29e4810dea298
config: c6x-randconfig-r013-20200802 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/rcupdate.h:28,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from arch/c6x/kernel/asm-offsets.c:8:
>> include/linux/bottom_half.h:10:74: error: expected ';', ',' or ')' before 'ip'
10 | static __always_inline void __local_bh_disable_ip(unsigned long __unused ip,
| ^~
include/linux/bottom_half.h: In function 'local_bh_disable':
>> include/linux/bottom_half.h:20:2: error: implicit declaration of function '__local_bh_disable_ip'; did you mean 'local_bh_disable'? [-Werror=implicit-function-declaration]
20 | __local_bh_disable_ip(_THIS_IP_, SOFTIRQ_DISABLE_OFFSET);
| ^~~~~~~~~~~~~~~~~~~~~
| local_bh_disable
arch/c6x/kernel/asm-offsets.c: At top level:
arch/c6x/kernel/asm-offsets.c:14:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
14 | void foo(void)
| ^~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:114: arch/c6x/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1175: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +10 include/linux/bottom_half.h
6
7 #ifdef CONFIG_TRACE_IRQFLAGS
8 extern void __local_bh_disable_ip(unsigned long ip, unsigned int cnt);
9 #else
> 10 static __always_inline void __local_bh_disable_ip(unsigned long __unused ip,
11 unsigned int cnt)
12 {
13 preempt_count_add(cnt);
14 barrier();
15 }
16 #endif
17
18 static inline void local_bh_disable(void)
19 {
> 20 __local_bh_disable_ip(_THIS_IP_, SOFTIRQ_DISABLE_OFFSET);
21 }
22
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26446 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-02 7:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 3:44 [PATCH] Modify the parameters that are not used leesagacious
2020-08-02 6:59 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).