* [PATCH] drm/nouveau/acr: fix a coding style in nvkm_acr_lsfw_load_bl_inst_data_sig()
@ 2020-08-03 3:48 Jing Xiangfeng
2020-08-03 10:42 ` [Nouveau] " Karol Herbst
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2020-08-03 3:48 UTC (permalink / raw)
To: bskeggs, airlied, daniel, jingxiangfeng; +Cc: dri-devel, nouveau, linux-kernel
This patch performs the following changes:
1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls
2. do assignment before this if condition, it is more readable
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index 07d1830126ab..5f6006418472 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -191,7 +191,8 @@ nvkm_acr_lsfw_load_bl_inst_data_sig(struct nvkm_subdev *subdev,
u32 *bldata;
int ret;
- if (IS_ERR((lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id))))
+ lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id);
+ if (IS_ERR(lsfw))
return PTR_ERR(lsfw);
ret = nvkm_firmware_load_name(subdev, path, "bl", ver, &bl);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/acr: fix a coding style in nvkm_acr_lsfw_load_bl_inst_data_sig()
2020-08-03 3:48 [PATCH] drm/nouveau/acr: fix a coding style in nvkm_acr_lsfw_load_bl_inst_data_sig() Jing Xiangfeng
@ 2020-08-03 10:42 ` Karol Herbst
0 siblings, 0 replies; 2+ messages in thread
From: Karol Herbst @ 2020-08-03 10:42 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: Ben Skeggs, David Airlie, Daniel Vetter, nouveau, LKML, dri-devel
Reviewed-by: Karol Herbst <kherbst@redhat.com>
On Mon, Aug 3, 2020 at 5:46 AM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
>
> This patch performs the following changes:
> 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls
> 2. do assignment before this if condition, it is more readable
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
> index 07d1830126ab..5f6006418472 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
> @@ -191,7 +191,8 @@ nvkm_acr_lsfw_load_bl_inst_data_sig(struct nvkm_subdev *subdev,
> u32 *bldata;
> int ret;
>
> - if (IS_ERR((lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id))))
> + lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id);
> + if (IS_ERR(lsfw))
> return PTR_ERR(lsfw);
>
> ret = nvkm_firmware_load_name(subdev, path, "bl", ver, &bl);
> --
> 2.17.1
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-03 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 3:48 [PATCH] drm/nouveau/acr: fix a coding style in nvkm_acr_lsfw_load_bl_inst_data_sig() Jing Xiangfeng
2020-08-03 10:42 ` [Nouveau] " Karol Herbst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).