* [PATCH net-next] fib: Fix undef compile warning
@ 2020-08-03 13:19 YueHaibing
2020-08-03 16:21 ` Brian Vazquez
2020-08-04 1:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-08-03 13:19 UTC (permalink / raw)
To: davem, kuba, brianvv, rdunlap; +Cc: netdev, linux-kernel, YueHaibing
net/core/fib_rules.c:26:7: warning: "CONFIG_IP_MULTIPLE_TABLES" is not defined, evaluates to 0 [-Wundef]
#elif CONFIG_IP_MULTIPLE_TABLES
^~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 8b66a6fd34f5 ("fib: fix another fib_rules_ops indirect call wrapper problem")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/core/fib_rules.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index a7a3f500a857..51678a528f85 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -23,7 +23,7 @@
#else
#define INDIRECT_CALL_MT(f, f2, f1, ...) INDIRECT_CALL_1(f, f2, __VA_ARGS__)
#endif
-#elif CONFIG_IP_MULTIPLE_TABLES
+#elif defined(CONFIG_IP_MULTIPLE_TABLES)
#define INDIRECT_CALL_MT(f, f2, f1, ...) INDIRECT_CALL_1(f, f1, __VA_ARGS__)
#else
#define INDIRECT_CALL_MT(f, f2, f1, ...) f(__VA_ARGS__)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] fib: Fix undef compile warning
2020-08-03 13:19 [PATCH net-next] fib: Fix undef compile warning YueHaibing
@ 2020-08-03 16:21 ` Brian Vazquez
2020-08-04 1:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Brian Vazquez @ 2020-08-03 16:21 UTC (permalink / raw)
To: YueHaibing; +Cc: David S . Miller, kuba, Randy Dunlap, Linux NetDev, open list
Acked-By: Brian Vazquez <brianvv@google.com>
On Mon, Aug 3, 2020 at 6:20 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> net/core/fib_rules.c:26:7: warning: "CONFIG_IP_MULTIPLE_TABLES" is not defined, evaluates to 0 [-Wundef]
> #elif CONFIG_IP_MULTIPLE_TABLES
> ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 8b66a6fd34f5 ("fib: fix another fib_rules_ops indirect call wrapper problem")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> net/core/fib_rules.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
> index a7a3f500a857..51678a528f85 100644
> --- a/net/core/fib_rules.c
> +++ b/net/core/fib_rules.c
> @@ -23,7 +23,7 @@
> #else
> #define INDIRECT_CALL_MT(f, f2, f1, ...) INDIRECT_CALL_1(f, f2, __VA_ARGS__)
> #endif
> -#elif CONFIG_IP_MULTIPLE_TABLES
> +#elif defined(CONFIG_IP_MULTIPLE_TABLES)
> #define INDIRECT_CALL_MT(f, f2, f1, ...) INDIRECT_CALL_1(f, f1, __VA_ARGS__)
> #else
> #define INDIRECT_CALL_MT(f, f2, f1, ...) f(__VA_ARGS__)
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] fib: Fix undef compile warning
2020-08-03 13:19 [PATCH net-next] fib: Fix undef compile warning YueHaibing
2020-08-03 16:21 ` Brian Vazquez
@ 2020-08-04 1:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-08-04 1:02 UTC (permalink / raw)
To: yuehaibing; +Cc: kuba, brianvv, rdunlap, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 3 Aug 2020 21:19:48 +0800
> net/core/fib_rules.c:26:7: warning: "CONFIG_IP_MULTIPLE_TABLES" is not defined, evaluates to 0 [-Wundef]
> #elif CONFIG_IP_MULTIPLE_TABLES
> ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 8b66a6fd34f5 ("fib: fix another fib_rules_ops indirect call wrapper problem")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thank for fixing this up.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-04 1:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 13:19 [PATCH net-next] fib: Fix undef compile warning YueHaibing
2020-08-03 16:21 ` Brian Vazquez
2020-08-04 1:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).