* [PATCH] io_uring: Fix use-after-free in io_sq_wq_submit_work()
@ 2020-08-05 3:40 Guoyu Huang
2020-08-05 19:10 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Guoyu Huang @ 2020-08-05 3:40 UTC (permalink / raw)
To: axboe, viro; +Cc: linux-block, linux-fsdevel, linux-kernel
when ctx->sqo_mm is zero, io_sq_wq_submit_work() frees 'req'
without deleting it from 'task_list'. After that, 'req' is
accessed in io_ring_ctx_wait_and_kill() which lead to
a use-after-free.
Signed-off-by: Guoyu Huang <hgy5945@gmail.com>
---
fs/io_uring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index e0200406765c..4b5ac381c67f 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2242,6 +2242,7 @@ static void io_sq_wq_submit_work(struct work_struct *work)
if (io_sqe_needs_user(sqe) && !cur_mm) {
if (!mmget_not_zero(ctx->sqo_mm)) {
ret = -EFAULT;
+ goto end_req;
} else {
cur_mm = ctx->sqo_mm;
use_mm(cur_mm);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io_uring: Fix use-after-free in io_sq_wq_submit_work()
2020-08-05 3:40 [PATCH] io_uring: Fix use-after-free in io_sq_wq_submit_work() Guoyu Huang
@ 2020-08-05 19:10 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-08-05 19:10 UTC (permalink / raw)
To: Guoyu Huang, viro; +Cc: linux-block, linux-fsdevel, linux-kernel
On 8/4/20 9:40 PM, Guoyu Huang wrote:
> when ctx->sqo_mm is zero, io_sq_wq_submit_work() frees 'req'
> without deleting it from 'task_list'. After that, 'req' is
> accessed in io_ring_ctx_wait_and_kill() which lead to
> a use-after-free.
This looks like an old one, that affects 5.4 only. I've massaged
it to apply on top of another fix, will ask to get it queued up for
stable. Thanks!
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-05 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-05 3:40 [PATCH] io_uring: Fix use-after-free in io_sq_wq_submit_work() Guoyu Huang
2020-08-05 19:10 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).