linux-next: Fixes tag needs some work in the watchdog tree

linux-next: Fixes tag needs some work in the watchdog tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

In commit

  95d0c04e0cf9 ("watchdog: f71808e_wdt: remove use of wrong watchdog_info option")

Fixes tag

  Fixes: 96cb4eb019ce ("watchdog: f71808e_wdt: new watchdog driver for

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the watchdog tree

[Ahmad Fatoum]

Hello Stephen,

On 8/5/20 12:26 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   95d0c04e0cf9 ("watchdog: f71808e_wdt: remove use of wrong watchdog_info option")
> 
> Fixes tag
> 
>   Fixes: 96cb4eb019ce ("watchdog: f71808e_wdt: new watchdog driver for
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

I wasn't sure of the convention. I will take care not to split in future.

Thanks!
Ahmad

> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: linux-next: Fixes tag needs some work in the watchdog tree

[Wim Van Sebroeck]

Hi Stephen,

Sorry for the delay. Fixed now.

Kind regards,
Wim.

> Hi all,
> 
> In commit
> 
>   1f7590ac16e7 ("watchdog: rti-wdt: Add missing pm_runtime_disable() in probe function")
> 
> Fixes tag
> 
>   Fixes: 2d63908 ("watchdog: Add K3 RTI watchdog support")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This an be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the watchdog tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

In commit

  1f7590ac16e7 ("watchdog: rti-wdt: Add missing pm_runtime_disable() in probe function")

Fixes tag

  Fixes: 2d63908 ("watchdog: Add K3 RTI watchdog support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This an be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]