From: peterz@infradead.org
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: mingo@redhat.com, oleg@redhat.com, acme@kernel.org,
jolsa@kernel.org, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com,
alexander.shishkin@linux.intel.com, mark.rutland@arm.com
Subject: Re: [PATCH v1 2/2] perf/core: Fake regs for leaked kernel samples
Date: Thu, 6 Aug 2020 11:24:54 +0200 [thread overview]
Message-ID: <20200806092454.GE35926@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200806091827.GY2674@hirez.programming.kicks-ass.net>
On Thu, Aug 06, 2020 at 11:18:27AM +0200, peterz@infradead.org wrote:
> On Thu, Aug 06, 2020 at 10:26:29AM +0800, Jin, Yao wrote:
>
> > > +static struct pt_regs *sanitize_sample_regs(struct perf_event *event, struct pt_regs *regs)
> > > +{
> > > + struct pt_regs *sample_regs = regs;
> > > +
> > > + /* user only */
> > > + if (!event->attr.exclude_kernel || !event->attr.exclude_hv ||
> > > + !event->attr.exclude_host || !event->attr.exclude_guest)
> > > + return sample_regs;
> > > +
> >
> > Is this condition correct?
> >
> > Say counting user event on host, exclude_kernel = 1 and exclude_host = 0. It
> > will go "return sample_regs" path.
>
> I'm not sure, I'm terminally confused on virt stuff.
[A]
> Suppose we have nested virt:
>
> L0-hv
> |
> G0/L1-hv
> |
> G1
>
> And we're running in G0, then:
>
> - 'exclude_hv' would exclude L0 events
> - 'exclude_host' would ... exclude L1-hv events?
> - 'exclude_guest' would ... exclude G1 events?
[B]
> Then the next question is, if G0 is a host, does the L1-hv run in
> G0 userspace or G0 kernel space?
>
> I was assuming G0 userspace would not include anything L1 (kvm is a
> kernel module after all), but what do I know.
>
> > > @@ -11609,7 +11636,8 @@ SYSCALL_DEFINE5(perf_event_open,
> > > if (err)
> > > return err;
> > > - if (!attr.exclude_kernel) {
> > > + if (!attr.exclude_kernel || !attr.exclude_callchain_kernel ||
> > > + !attr.exclude_hv || !attr.exclude_host || !attr.exclude_guest) {
> > > err = perf_allow_kernel(&attr);
> > > if (err)
> > > return err;
> > >
> >
> > I can understand the conditions "!attr.exclude_kernel || !attr.exclude_callchain_kernel".
> >
> > But I'm not very sure about the "!attr.exclude_hv || !attr.exclude_host || !attr.exclude_guest".
>
> Well, I'm very sure G0 userspace should never see L0 or G1 state, so
> exclude_hv and exclude_guest had better be true.
>
> > On host, exclude_hv = 1, exclude_guest = 1 and exclude_host = 0, right?
>
> Same as above, is G0 host state G0 userspace?
>
> > So even exclude_kernel = 1 but exclude_host = 0, we will still go
> > perf_allow_kernel path. Please correct me if my understanding is wrong.
>
> Yes, because with those permission checks in place it means you have
> permission to see kernel bits.
So if I understand 'exclude_host' wrong -- a distinct possibility -- can
we then pretty please have the above [A-B] corrected and put in a
comment near perf_event_attr and the exclude_* comments changed to refer
to that?
next prev parent reply other threads:[~2020-08-06 11:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 2:56 [PATCH v1 1/2] Missing instruction_pointer_set() instances Jin Yao
2020-07-31 2:56 ` [PATCH v1 2/2] perf/core: Fake regs for leaked kernel samples Jin Yao
2020-08-04 11:49 ` peterz
2020-08-05 2:15 ` Jin, Yao
2020-08-05 12:44 ` peterz
2020-08-05 12:57 ` peterz
2020-08-06 2:26 ` Jin, Yao
2020-08-06 9:18 ` peterz
2020-08-06 9:24 ` peterz [this message]
2020-08-07 5:32 ` Jin, Yao
2020-08-06 11:00 ` peterz
2020-08-07 6:24 ` Jin, Yao
2020-08-07 9:02 ` peterz
2020-08-10 2:03 ` Jin, Yao
2020-08-07 5:23 ` Jin, Yao
2020-08-11 7:50 ` Jin, Yao
2020-08-11 7:59 ` Peter Zijlstra
2020-08-11 8:31 ` Jin, Yao
2020-08-11 8:45 ` Peter Zijlstra
2020-08-12 3:52 ` Jin, Yao
2020-08-12 7:25 ` Like Xu
2020-08-04 11:31 ` [PATCH v1 1/2] Missing instruction_pointer_set() instances peterz
2020-08-05 0:26 ` Jin, Yao
2020-08-04 21:31 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806092454.GE35926@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).