From: Rob Herring <robh@kernel.org>
To: pisa@cmp.felk.cvut.cz
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
mkl@pengutronix.de, socketcan@hartkopp.net, wg@grandegger.com,
davem@davemloft.net, mark.rutland@arm.com, c.emde@osadl.org,
armbru@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, martin.jerabek01@gmail.com,
ondrej.ille@gmail.com, jnovak@fel.cvut.cz, jara.beran@gmail.com,
porazil@pikron.com
Subject: Re: [PATCH v4 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core.
Date: Thu, 6 Aug 2020 08:43:45 -0600 [thread overview]
Message-ID: <20200806144345.GA822372@bogus> (raw)
In-Reply-To: <701442883f2b439637ff84544745725bdee7bcf8.1596408856.git.pisa@cmp.felk.cvut.cz>
On Mon, Aug 03, 2020 at 08:34:50PM +0200, pisa@cmp.felk.cvut.cz wrote:
> From: Pavel Pisa <pisa@cmp.felk.cvut.cz>
>
> The device-tree bindings for open-source CAN FD IP core
> which design started at Department of Measurement
> at Faculty of Electrical Engineering
> of Czech Technical University in Prague.
> The IP core main author is Ondrej Ille who continues
> on the core development even after finishing the studies.
>
> The CTU CAN FD IP core main repository
>
> https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core
>
> The list of related CAN bus projects which we participate in
>
> http://canbus.pages.fel.cvut.cz/
>
> The commit text again to make checkpatch happy.
>
> Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> ---
> .../devicetree/bindings/net/can/ctu,ctucanfd.yaml | 70 ++++++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml b/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml
> new file mode 100644
> index 000000000000..b74bfc951062
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/ctu,ctucanfd.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/can/ctu,ctucanfd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CTU CAN FD Open-source IP Core Device Tree Bindings
> +
> +description: |
> + Open-source CAN FD IP core developed at the Czech Technical University in Prague
> +
> + The core sources and documentation on project page
> + [1] sources : https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core
> + [2] datasheet : https://canbus.pages.fel.cvut.cz/ctucanfd_ip_core/Progdokum.pdf
> +
> + Integration in Xilinx Zynq SoC based system together with
> + OpenCores SJA1000 compatible controllers
> + [3] project : https://gitlab.fel.cvut.cz/canbus/zynq/zynq-can-sja1000-top
> + Martin Jerabek dimploma thesis with integration and testing
> + framework description
> + [4] PDF : https://dspace.cvut.cz/bitstream/handle/10467/80366/F3-DP-2019-Jerabek-Martin-Jerabek-thesis-2019-canfd.pdf
> +
> +maintainers:
> + - Pavel Pisa <pisa@cmp.felk.cvut.cz>
> + - Ondrej Ille <ondrej.ille@gmail.com>
> + - Martin Jerabek <martin.jerabek01@gmail.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: ctu,ctucanfd
> + - const: ctu,canfd-2
The order is supposed to be be most specific compatible first, but this
seems backwards given 'ctu,ctucanfd' alone is allowed.
> + - const: ctu,ctucanfd
> +
> + reg:
> + description:
> + mapping into bus address space, offset and size
No need to describe common properties unless you have something specific
to this device to say.
> + maxItems: 1
> +
> + interrupts:
> + description: |
> + interrupt source. For Zynq SoC system, format is <(is_spi) (number) (type)>
> + where is_spi defines if it is SPI (shared peripheral) interrupt,
> + the second number is translated to the vector by addition of 32
> + on Zynq-7000 systems and type is IRQ_TYPE_LEVEL_HIGH (4) for Zynq.
That's all outside the scope of this binding.
> + maxItems: 1
> +
> + clocks:
> + description: |
> + phandle of reference clock (100 MHz is appropriate
> + for FPGA implementation on Zynq-7000 system).
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + ctu_can_fd_0: can@43c30000 {
> + compatible = "ctu,ctucanfd";
> + interrupts = <0 30 4>;
> + clocks = <&clkc 15>;
> + reg = <0x43c30000 0x10000>;
> + };
> --
> 2.11.0
>
next prev parent reply other threads:[~2020-08-06 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 18:34 [PATCH v4 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation pisa
2020-08-03 18:34 ` [PATCH v4 1/6] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague pisa
2020-08-03 18:34 ` [PATCH v4 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core pisa
2020-08-04 9:18 ` Pavel Machek
2020-08-04 9:20 ` Pavel Machek
2020-08-06 14:47 ` Rob Herring
2020-08-06 15:53 ` Pavel Pisa
2020-08-06 14:43 ` Rob Herring [this message]
2020-08-03 18:34 ` [PATCH v4 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part pisa
2020-08-04 9:57 ` Pavel Machek
2020-08-03 18:34 ` [PATCH v4 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support pisa
2020-08-03 19:32 ` Randy Dunlap
2020-08-03 18:34 ` [PATCH v4 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support pisa
2020-08-03 18:34 ` [PATCH v4 6/6] docs: ctucanfd: CTU CAN FD open-source IP core documentation pisa
2020-08-03 20:29 ` [PATCH v4 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806144345.GA822372@bogus \
--to=robh@kernel.org \
--cc=armbru@redhat.com \
--cc=c.emde@osadl.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jara.beran@gmail.com \
--cc=jnovak@fel.cvut.cz \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.jerabek01@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=porazil@pikron.com \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).