ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()

ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()

[brookxu]

Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
code has already judged whether page is NULL.

Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
 fs/ext4/mballoc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 28a139f..9b1c3ad 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1279,9 +1279,6 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group, gfp_t gfp)
     e4b->bd_buddy_page = page;
     e4b->bd_buddy = page_address(page) + (poff * sb->s_blocksize);
 
-    BUG_ON(e4b->bd_bitmap_page == NULL);
-    BUG_ON(e4b->bd_buddy_page == NULL);
-
     return 0;
 
 err:
-- 
1.8.3.1

Re: ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()

[Ritesh Harjani]

On 7/27/20 7:24 AM, brookxu wrote:
> Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
> code has already judged whether page is NULL.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Thanks for the patch. LGTM. Feel free to add.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

> ---
>   fs/ext4/mballoc.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 28a139f..9b1c3ad 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1279,9 +1279,6 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group, gfp_t gfp)
>       e4b->bd_buddy_page = page;
>       e4b->bd_buddy = page_address(page) + (poff * sb->s_blocksize);
>   
> -    BUG_ON(e4b->bd_bitmap_page == NULL);
> -    BUG_ON(e4b->bd_buddy_page == NULL);
> -
>       return 0;
>   
>   err:
> 

Re: ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()

[Theodore Ts'o]

On Mon, Jul 27, 2020 at 09:54:14AM +0800, brookxu wrote:
> Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
> code has already judged whether page is NULL.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Applied, but I had to manually apply your patch since it was mangled
by your mailer.

It looks like the problem may have been caused by your using gmail;
please take a look at the file Documentation/process/email-clients.rst for some hints.

							- Ted