* [PATCH 01/20] media: sunxi: sun8i-rotate.c: remove useless error message
@ 2020-08-07 8:35 Daniel W. S. Almeida
0 siblings, 0 replies; only message in thread
From: Daniel W. S. Almeida @ 2020-08-07 8:35 UTC (permalink / raw)
To: Jernej Skrabec, Maxime Ripard, Chen-Yu Tsai
Cc: skhan, Daniel W. S. Almeida, Mauro Carvalho Chehab, linux-media,
linux-arm-kernel, linux-kernel
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
This fixes the following coccinelle report:
drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c:751:2-9:
line 751 is redundant because platform_get_irq() already prints an error
By removing the useless call to dev_err()
Found using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c
index 94f505d3cbad..3f81dd17755c 100644
--- a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c
+++ b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c
@@ -747,11 +747,8 @@ static int rotate_probe(struct platform_device *pdev)
dev->dev = &pdev->dev;
irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
- dev_err(dev->dev, "Failed to get IRQ\n");
-
+ if (irq <= 0)
return irq;
- }
ret = devm_request_irq(dev->dev, irq, rotate_irq,
0, dev_name(dev->dev), dev);
--
2.28.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-07 8:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 8:35 [PATCH 01/20] media: sunxi: sun8i-rotate.c: remove useless error message Daniel W. S. Almeida
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).