* [PATCH] powerpc:entry_32: correct the path and function name in the comment
@ 2020-08-07 10:19 chenzefeng
2020-08-07 14:31 ` Christophe Leroy
2022-03-15 9:58 ` Christophe Leroy
0 siblings, 2 replies; 3+ messages in thread
From: chenzefeng @ 2020-08-07 10:19 UTC (permalink / raw)
To: mpe, benh, paulus, christophe.leroy, tglx, chenzefeng2, bigeasy, npiggin
Cc: linuxppc-dev, linux-kernel, zengweilin
Update the comment for file's directory and function name changed.
Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls")
Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")
Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
---
arch/powerpc/kernel/entry_32.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index 8420abd4ea1c..9937593d3a33 100644
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S
@@ -696,8 +696,8 @@ handle_dabr_fault:
* to the "_switch" path. If you change this , you'll have to
* change the fork code also.
*
- * The code which creates the new task context is in 'copy_thread'
- * in arch/ppc/kernel/process.c
+ * The code which creates the new task context is in 'copy_thread_tls'
+ * in arch/powerpc/kernel/process.c
*/
_GLOBAL(_switch)
stwu r1,-INT_FRAME_SIZE(r1)
--
2.12.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc:entry_32: correct the path and function name in the comment
2020-08-07 10:19 [PATCH] powerpc:entry_32: correct the path and function name in the comment chenzefeng
@ 2020-08-07 14:31 ` Christophe Leroy
2022-03-15 9:58 ` Christophe Leroy
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy @ 2020-08-07 14:31 UTC (permalink / raw)
To: chenzefeng, mpe, benh, paulus, christophe.leroy, tglx, bigeasy, npiggin
Cc: linuxppc-dev, linux-kernel, zengweilin
Le 07/08/2020 à 12:19, chenzefeng a écrit :
> Update the comment for file's directory and function name changed.
>
> Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls")
> Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")
>
> Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
> ---
> arch/powerpc/kernel/entry_32.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
> index 8420abd4ea1c..9937593d3a33 100644
> --- a/arch/powerpc/kernel/entry_32.S
> +++ b/arch/powerpc/kernel/entry_32.S
> @@ -696,8 +696,8 @@ handle_dabr_fault:
> * to the "_switch" path. If you change this , you'll have to
> * change the fork code also.
> *
> - * The code which creates the new task context is in 'copy_thread'
> - * in arch/ppc/kernel/process.c
> + * The code which creates the new task context is in 'copy_thread_tls'
> + * in arch/powerpc/kernel/process.c
Does it matters at all where the function is ? I'm sure people can find
it themselves.
Christophe
> */
> _GLOBAL(_switch)
> stwu r1,-INT_FRAME_SIZE(r1)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc:entry_32: correct the path and function name in the comment
2020-08-07 10:19 [PATCH] powerpc:entry_32: correct the path and function name in the comment chenzefeng
2020-08-07 14:31 ` Christophe Leroy
@ 2022-03-15 9:58 ` Christophe Leroy
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy @ 2022-03-15 9:58 UTC (permalink / raw)
To: chenzefeng, mpe, benh, paulus, christophe.leroy, tglx, bigeasy, npiggin
Cc: linuxppc-dev, linux-kernel, zengweilin
Le 07/08/2020 à 12:19, chenzefeng a écrit :
> Update the comment for file's directory and function name changed.
The function name changed again with commit 714acdbd1c94 ("arch: rename
copy_thread_tls() back to copy_thread()")
Please update the patch to just drop the file name. Users are able to
find where the function is by themselves.
Thanks
Christophe
>
> Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls")
> Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")
>
> Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
> ---
> arch/powerpc/kernel/entry_32.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
> index 8420abd4ea1c..9937593d3a33 100644
> --- a/arch/powerpc/kernel/entry_32.S
> +++ b/arch/powerpc/kernel/entry_32.S
> @@ -696,8 +696,8 @@ handle_dabr_fault:
> * to the "_switch" path. If you change this , you'll have to
> * change the fork code also.
> *
> - * The code which creates the new task context is in 'copy_thread'
> - * in arch/ppc/kernel/process.c
> + * The code which creates the new task context is in 'copy_thread_tls'
> + * in arch/powerpc/kernel/process.c
> */
> _GLOBAL(_switch)
> stwu r1,-INT_FRAME_SIZE(r1)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 10:19 [PATCH] powerpc:entry_32: correct the path and function name in the comment chenzefeng
2020-08-07 14:31 ` Christophe Leroy
2022-03-15 9:58 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).