From: Jean Delvare <jdelvare@suse.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux I2C <linux-i2c@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: VAIO EEPROM support in at24
Date: Fri, 7 Aug 2020 11:31:46 +0200 [thread overview]
Message-ID: <20200807113146.7557c18b@endymion> (raw)
In-Reply-To: <20200805163655.6cfa6e17@endymion>
On Wed, 5 Aug 2020 16:36:55 +0200, Jean Delvare wrote:
> 1* Do we actually need to use a struct resource? With the current
> requirements, that looks overkill to me. We really only need the
> start and end offsets of the masked area (or start and length). Or
> do you plan to ever support multiple masked ranges, and
> resource.child would be used to daisy-chain these ranges? Personally
> I would wait until the need exists.
Dang, turns out that the need already exists. I just found that the
eeprom driver masks *2* areas of the Sony VAIO EEPROMs. I should know
because I'm the one who made that change but that was 13 years ago and
my memory doesn't go that far back.
I'll think of a way to support that. Still not a big fan of
daisy-chained resource structs though. Maybe a generic post-processing
callback function would do... I'll give that a try.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2020-08-07 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 14:14 VAIO EEPROM support in at24 Jean Delvare
2020-03-17 14:32 ` Bartosz Golaszewski
2020-03-17 15:01 ` Wolfram Sang
2020-08-03 14:53 ` Jean Delvare
2020-08-05 14:36 ` Jean Delvare
2020-08-05 18:14 ` Bartosz Golaszewski
2020-08-06 12:14 ` Jean Delvare
2020-08-07 9:31 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807113146.7557c18b@endymion \
--to=jdelvare@suse.de \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).