* [PATCH] hwrng : cleanup initialization
@ 2020-08-09 15:04 trix
2020-08-21 7:58 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-08-09 15:04 UTC (permalink / raw)
To: mpm, herbert, arnd, gregkh; +Cc: linux-crypto, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
clang static analysis reports this problem
intel-rng.c:333:2: warning: Assigned value is garbage or undefined
void __iomem *mem = mem;
^~~~~~~~~~~~~~~~~ ~~~
Because mem is assigned before it is used, this is not
a real problem. But the initialization is strange and not
needed, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/char/hw_random/intel-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/intel-rng.c b/drivers/char/hw_random/intel-rng.c
index 9f205bd1acc0..eb7db27f9f19 100644
--- a/drivers/char/hw_random/intel-rng.c
+++ b/drivers/char/hw_random/intel-rng.c
@@ -330,7 +330,7 @@ static int __init mod_init(void)
int err = -ENODEV;
int i;
struct pci_dev *dev = NULL;
- void __iomem *mem = mem;
+ void __iomem *mem;
u8 hw_status;
struct intel_rng_hw *intel_rng_hw;
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwrng : cleanup initialization
2020-08-09 15:04 [PATCH] hwrng : cleanup initialization trix
@ 2020-08-21 7:58 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-08-21 7:58 UTC (permalink / raw)
To: trix; +Cc: mpm, arnd, gregkh, linux-crypto, linux-kernel
On Sun, Aug 09, 2020 at 08:04:23AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports this problem
>
> intel-rng.c:333:2: warning: Assigned value is garbage or undefined
> void __iomem *mem = mem;
> ^~~~~~~~~~~~~~~~~ ~~~
>
> Because mem is assigned before it is used, this is not
> a real problem. But the initialization is strange and not
> needed, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/char/hw_random/intel-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-21 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-09 15:04 [PATCH] hwrng : cleanup initialization trix
2020-08-21 7:58 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).