* [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling
@ 2020-08-11 6:24 Anson Huang
2020-08-11 6:24 ` [PATCH V2 2/3] pwm: imx27: " Anson Huang
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Anson Huang @ 2020-08-11 6:24 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, shawnguo, s.hauer,
kernel, festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
- remove redundant return value print.
---
drivers/pwm/pwm-imx-tpm.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c
index fcdf6be..aaf629b 100644
--- a/drivers/pwm/pwm-imx-tpm.c
+++ b/drivers/pwm/pwm-imx-tpm.c
@@ -350,13 +350,9 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev)
return PTR_ERR(tpm->base);
tpm->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(tpm->clk)) {
- ret = PTR_ERR(tpm->clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "failed to get PWM clock: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(tpm->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(tpm->clk),
+ "failed to get PWM clock\n");
ret = clk_prepare_enable(tpm->clk);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 2/3] pwm: imx27: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
@ 2020-08-11 6:24 ` Anson Huang
2020-08-11 6:37 ` Lee Jones
2020-08-11 7:00 ` Uwe Kleine-König
2020-08-11 6:24 ` [PATCH V2 3/3] pwm: imx1: " Anson Huang
` (4 subsequent siblings)
5 siblings, 2 replies; 11+ messages in thread
From: Anson Huang @ 2020-08-11 6:24 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, shawnguo, s.hauer,
kernel, festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
- remove redundant return value print.
---
drivers/pwm/pwm-imx27.c | 25 ++++++-------------------
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index c50d453..ceaed03 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -315,27 +315,14 @@ static int pwm_imx27_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, imx);
imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
- if (IS_ERR(imx->clk_ipg)) {
- int ret = PTR_ERR(imx->clk_ipg);
-
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "getting ipg clock failed with %d\n",
- ret);
- return ret;
- }
+ if (IS_ERR(imx->clk_ipg))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_ipg),
+ "getting ipg clock failed\n");
imx->clk_per = devm_clk_get(&pdev->dev, "per");
- if (IS_ERR(imx->clk_per)) {
- int ret = PTR_ERR(imx->clk_per);
-
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "failed to get peripheral clock: %d\n",
- ret);
-
- return ret;
- }
+ if (IS_ERR(imx->clk_per))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_per),
+ "failed to get peripheral clock\n");
imx->chip.ops = &pwm_imx27_ops;
imx->chip.dev = &pdev->dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 3/3] pwm: imx1: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 6:24 ` [PATCH V2 2/3] pwm: imx27: " Anson Huang
@ 2020-08-11 6:24 ` Anson Huang
2020-08-11 6:37 ` Lee Jones
2020-08-11 6:58 ` Uwe Kleine-König
2020-08-11 6:37 ` [PATCH V2 1/3] pwm: imx-tpm: " Lee Jones
` (3 subsequent siblings)
5 siblings, 2 replies; 11+ messages in thread
From: Anson Huang @ 2020-08-11 6:24 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, shawnguo, s.hauer,
kernel, festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
- remove redundant return value print.
---
drivers/pwm/pwm-imx1.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/drivers/pwm/pwm-imx1.c b/drivers/pwm/pwm-imx1.c
index f8b2c2e..4877734 100644
--- a/drivers/pwm/pwm-imx1.c
+++ b/drivers/pwm/pwm-imx1.c
@@ -145,23 +145,14 @@ static int pwm_imx1_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, imx);
imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
- if (IS_ERR(imx->clk_ipg)) {
- dev_err(&pdev->dev, "getting ipg clock failed with %ld\n",
- PTR_ERR(imx->clk_ipg));
- return PTR_ERR(imx->clk_ipg);
- }
+ if (IS_ERR(imx->clk_ipg))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_ipg),
+ "getting ipg clock failed\n");
imx->clk_per = devm_clk_get(&pdev->dev, "per");
- if (IS_ERR(imx->clk_per)) {
- int ret = PTR_ERR(imx->clk_per);
-
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "failed to get peripheral clock: %d\n",
- ret);
-
- return ret;
- }
+ if (IS_ERR(imx->clk_per))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_per),
+ "failed to get peripheral clock\n");
imx->chip.ops = &pwm_imx1_ops;
imx->chip.dev = &pdev->dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 6:24 ` [PATCH V2 2/3] pwm: imx27: " Anson Huang
2020-08-11 6:24 ` [PATCH V2 3/3] pwm: imx1: " Anson Huang
@ 2020-08-11 6:37 ` Lee Jones
2020-08-11 7:00 ` Uwe Kleine-König
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2020-08-11 6:37 UTC (permalink / raw)
To: Anson Huang
Cc: thierry.reding, u.kleine-koenig, shawnguo, s.hauer, kernel,
festevam, linux-pwm, linux-arm-kernel, linux-kernel, Linux-imx
On Tue, 11 Aug 2020, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> - remove redundant return value print.
> ---
> drivers/pwm/pwm-imx-tpm.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 2/3] pwm: imx27: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 ` [PATCH V2 2/3] pwm: imx27: " Anson Huang
@ 2020-08-11 6:37 ` Lee Jones
2020-08-11 7:00 ` Uwe Kleine-König
1 sibling, 0 replies; 11+ messages in thread
From: Lee Jones @ 2020-08-11 6:37 UTC (permalink / raw)
To: Anson Huang
Cc: thierry.reding, u.kleine-koenig, shawnguo, s.hauer, kernel,
festevam, linux-pwm, linux-arm-kernel, linux-kernel, Linux-imx
On Tue, 11 Aug 2020, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> - remove redundant return value print.
> ---
> drivers/pwm/pwm-imx27.c | 25 ++++++-------------------
> 1 file changed, 6 insertions(+), 19 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 3/3] pwm: imx1: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 ` [PATCH V2 3/3] pwm: imx1: " Anson Huang
@ 2020-08-11 6:37 ` Lee Jones
2020-08-11 6:58 ` Uwe Kleine-König
1 sibling, 0 replies; 11+ messages in thread
From: Lee Jones @ 2020-08-11 6:37 UTC (permalink / raw)
To: Anson Huang
Cc: thierry.reding, u.kleine-koenig, shawnguo, s.hauer, kernel,
festevam, linux-pwm, linux-arm-kernel, linux-kernel, Linux-imx
On Tue, 11 Aug 2020, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> - remove redundant return value print.
> ---
> drivers/pwm/pwm-imx1.c | 21 ++++++---------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 3/3] pwm: imx1: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 ` [PATCH V2 3/3] pwm: imx1: " Anson Huang
2020-08-11 6:37 ` Lee Jones
@ 2020-08-11 6:58 ` Uwe Kleine-König
1 sibling, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2020-08-11 6:58 UTC (permalink / raw)
To: Anson Huang
Cc: thierry.reding, lee.jones, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel, Linux-imx
[-- Attachment #1: Type: text/plain, Size: 1763 bytes --]
On Tue, Aug 11, 2020 at 02:24:32PM +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> - remove redundant return value print.
> ---
> drivers/pwm/pwm-imx1.c | 21 ++++++---------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx1.c b/drivers/pwm/pwm-imx1.c
> index f8b2c2e..4877734 100644
> --- a/drivers/pwm/pwm-imx1.c
> +++ b/drivers/pwm/pwm-imx1.c
> @@ -145,23 +145,14 @@ static int pwm_imx1_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, imx);
>
> imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
> - if (IS_ERR(imx->clk_ipg)) {
> - dev_err(&pdev->dev, "getting ipg clock failed with %ld\n",
> - PTR_ERR(imx->clk_ipg));
> - return PTR_ERR(imx->clk_ipg);
> - }
> + if (IS_ERR(imx->clk_ipg))
> + return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_ipg),
> + "getting ipg clock failed\n");
>
> imx->clk_per = devm_clk_get(&pdev->dev, "per");
> - if (IS_ERR(imx->clk_per)) {
> - int ret = PTR_ERR(imx->clk_per);
> -
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "failed to get peripheral clock: %d\n",
> - ret);
> -
> - return ret;
> - }
> + if (IS_ERR(imx->clk_per))
> + return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_per),
> + "failed to get peripheral clock\n");
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 2/3] pwm: imx27: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 ` [PATCH V2 2/3] pwm: imx27: " Anson Huang
2020-08-11 6:37 ` Lee Jones
@ 2020-08-11 7:00 ` Uwe Kleine-König
1 sibling, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2020-08-11 7:00 UTC (permalink / raw)
To: Anson Huang
Cc: thierry.reding, lee.jones, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel, Linux-imx
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
On Tue, Aug 11, 2020 at 02:24:31PM +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
` (2 preceding siblings ...)
2020-08-11 6:37 ` [PATCH V2 1/3] pwm: imx-tpm: " Lee Jones
@ 2020-08-11 7:00 ` Uwe Kleine-König
2020-09-17 6:37 ` Anson Huang
2020-11-11 18:05 ` Thierry Reding
5 siblings, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2020-08-11 7:00 UTC (permalink / raw)
To: Anson Huang
Cc: thierry.reding, lee.jones, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel, Linux-imx
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Tue, Aug 11, 2020 at 02:24:30PM +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
` (3 preceding siblings ...)
2020-08-11 7:00 ` Uwe Kleine-König
@ 2020-09-17 6:37 ` Anson Huang
2020-11-11 18:05 ` Thierry Reding
5 siblings, 0 replies; 11+ messages in thread
From: Anson Huang @ 2020-09-17 6:37 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, shawnguo, s.hauer,
kernel, festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: dl-linux-imx
Gentle ping...
> Subject: [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error
> handling
>
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> - remove redundant return value print.
> ---
> drivers/pwm/pwm-imx-tpm.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c index
> fcdf6be..aaf629b 100644
> --- a/drivers/pwm/pwm-imx-tpm.c
> +++ b/drivers/pwm/pwm-imx-tpm.c
> @@ -350,13 +350,9 @@ static int pwm_imx_tpm_probe(struct
> platform_device *pdev)
> return PTR_ERR(tpm->base);
>
> tpm->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(tpm->clk)) {
> - ret = PTR_ERR(tpm->clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "failed to get PWM clock: %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(tpm->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(tpm->clk),
> + "failed to get PWM clock\n");
>
> ret = clk_prepare_enable(tpm->clk);
> if (ret) {
> --
> 2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling
2020-08-11 6:24 [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
` (4 preceding siblings ...)
2020-09-17 6:37 ` Anson Huang
@ 2020-11-11 18:05 ` Thierry Reding
5 siblings, 0 replies; 11+ messages in thread
From: Thierry Reding @ 2020-11-11 18:05 UTC (permalink / raw)
To: Anson Huang
Cc: u.kleine-koenig, lee.jones, shawnguo, s.hauer, kernel, festevam,
linux-pwm, linux-arm-kernel, linux-kernel, Linux-imx
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
On Tue, Aug 11, 2020 at 02:24:30PM +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> - remove redundant return value print.
> ---
> drivers/pwm/pwm-imx-tpm.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
All three patches applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-11-11 18:05 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 6:24 [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 6:24 ` [PATCH V2 2/3] pwm: imx27: " Anson Huang
2020-08-11 6:37 ` Lee Jones
2020-08-11 7:00 ` Uwe Kleine-König
2020-08-11 6:24 ` [PATCH V2 3/3] pwm: imx1: " Anson Huang
2020-08-11 6:37 ` Lee Jones
2020-08-11 6:58 ` Uwe Kleine-König
2020-08-11 6:37 ` [PATCH V2 1/3] pwm: imx-tpm: " Lee Jones
2020-08-11 7:00 ` Uwe Kleine-König
2020-09-17 6:37 ` Anson Huang
2020-11-11 18:05 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).