[PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

[PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

[Christian König]

From: Guchun Chen <guchun.chen@amd.com>

Otherwise, braces are needed when using it.

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
 include/linux/rwsem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 7e5b2a4eb560..7a5bf5d50489 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -179,7 +179,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
 do {								\
 	typecheck(struct lockdep_map *, &(nest_lock)->dep_map);	\
 	_down_write_nest_lock(sem, &(nest_lock)->dep_map);	\
-} while (0);
+} while (0)
 
 /*
  * Take/release a lock when not the owner will release it.
-- 
2.25.1

Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

[peterz]

On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
> From: Guchun Chen <guchun.chen@amd.com>
> 
> Otherwise, braces are needed when using it.
> 
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>

Thanks!

Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

[Christian König]

Am 12.08.20 um 10:10 schrieb peterz@infradead.org:
> On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
>> From: Guchun Chen <guchun.chen@amd.com>
>>
>> Otherwise, braces are needed when using it.
>>
>> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
> Thanks!

Do you pick it up or can I push it through drm-misc-fixes?

If the former please let me know when it hits Linus tree since I have a 
driver which contains some extra {} because of this.

Thanks,
Christian.

Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

[peterz]

On Wed, Aug 12, 2020 at 10:36:14AM +0200, Christian König wrote:
> Am 12.08.20 um 10:10 schrieb peterz@infradead.org:
> > On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
> > > From: Guchun Chen <guchun.chen@amd.com>
> > > 
> > > Otherwise, braces are needed when using it.
> > > 
> > > Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> > > Reviewed-by: Christian König <christian.koenig@amd.com>
> > Thanks!
> 
> Do you pick it up or can I push it through drm-misc-fixes?
> 
> If the former please let me know when it hits Linus tree since I have a
> driver which contains some extra {} because of this.

Oh, in that case you can take it:

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

and I'll drop it from my quilt series.