From: Peter Zijlstra <peterz@infradead.org>
To: Jessica Yu <jeyu@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
keescook@chromium.org, Josh Poimboeuf <jpoimboe@redhat.com>,
Miroslav Benes <mbenes@suse.cz>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v2] module: Harden STRICT_MODULE_RWX
Date: Tue, 11 Aug 2020 23:29:08 +0200 [thread overview]
Message-ID: <20200811212908.GB5637@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20200811175912.GF2674@hirez.programming.kicks-ass.net>
On Tue, Aug 11, 2020 at 07:59:12PM +0200, peterz@infradead.org wrote:
> On Tue, Aug 11, 2020 at 06:01:35PM +0200, Jessica Yu wrote:
>
> > > > On Tue, Aug 11, 2020 at 04:34:27PM +0200, Mauro Carvalho Chehab wrote:
> > > > > [33] .plt PROGBITS 0000000000000340 00035c80
> > > > > 0000000000000001 0000000000000000 WAX 0 0 1
> > > > > [34] .init.plt NOBITS 0000000000000341 00035c81
> > > > > 0000000000000001 0000000000000000 WA 0 0 1
> > > > > [35] .text.ftrace[...] PROGBITS 0000000000000342 00035c81
> > > > > 0000000000000001 0000000000000000 WAX 0 0 1
>
> > Interesting, my cross-compiled modules do not have the executable flag -
> >
> > [38] .plt NOBITS 0000000000000340 00038fc0
> > 0000000000000001 0000000000000000 WA 0 0 1
> > [39] .init.plt NOBITS 0000000000000341 00038fc0
> > 0000000000000001 0000000000000000 WA 0 0 1
> > [40] .text.ftrace_tram NOBITS 0000000000000342 00038fc0
> > 0000000000000001 0000000000000000 WA 0 0 1
>
> > I'm a bit confused about what NOLOAD actually implies in this context. From the
> > ld documentation - "The `(NOLOAD)' directive will mark a section to not be
> > loaded at run time." But these sections are marked SHF_ALLOC and are referenced
> > to in the module plt code. Or does it just tell the linker to not initialize it?
>
> Yeah, that confusion is wide-spread, so much so that bfd-ld and gold,
> both in bintils, had different behaviour at some point.
>
> Anyway, another clue is that your build has all NOBITS, while Mauro's
> build has PROGBITS for the broken sections.
>
> Anyway, my gcc-10.1/binutils-2.34 cross tool chain (from k.org)
> generates the same as Jessica's too. I wonder if binutils-2.35 is
> wonky...
When I use the Debian provided cross compiler which uses:
binutils-aarch64-linux-gnu 2.35-1
I do indeed see the same thing Mauro does, which seems to suggest
there's something really dodgy with that toolchain. Some tools person
should have a look.
next prev parent reply other threads:[~2020-08-11 21:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 17:13 [PATCH v2] module: Harden STRICT_MODULE_RWX Peter Zijlstra
2020-04-03 20:31 ` Kees Cook
2020-04-08 15:32 ` Jessica Yu
2020-04-08 15:43 ` [PATCH] module: break nested ARCH_HAS_STRICT_MODULE_RWX and STRICT_MODULE_RWX #ifdefs Jessica Yu
2020-04-08 15:57 ` [PATCH v2] module: Harden STRICT_MODULE_RWX Peter Zijlstra
2020-04-08 16:20 ` Jessica Yu
2020-08-08 8:12 ` Mauro Carvalho Chehab
2020-08-10 9:25 ` Jessica Yu
2020-08-10 15:06 ` Jessica Yu
2020-08-11 14:34 ` Mauro Carvalho Chehab
2020-08-11 14:55 ` peterz
2020-08-11 15:27 ` Mauro Carvalho Chehab
2020-08-11 16:01 ` Jessica Yu
2020-08-11 16:57 ` Will Deacon
2020-08-11 17:59 ` peterz
2020-08-11 21:29 ` Peter Zijlstra [this message]
2020-08-12 8:56 ` Ard Biesheuvel
2020-08-12 10:40 ` peterz
2020-08-12 11:41 ` Jessica Yu
2020-08-12 13:14 ` H.J. Lu
2020-08-12 12:56 ` Will Deacon
2020-08-12 14:15 ` Szabolcs Nagy
2020-08-12 16:00 ` Jessica Yu
2020-08-12 16:37 ` Ard Biesheuvel
2020-08-12 16:42 ` Szabolcs Nagy
2020-08-13 9:00 ` Will Deacon
2020-08-12 20:00 ` Peter Zijlstra
2020-08-13 8:36 ` Ard Biesheuvel
2020-08-13 13:04 ` Jessica Yu
2020-08-13 13:07 ` Ard Biesheuvel
2020-08-21 12:20 ` Will Deacon
2020-08-21 12:27 ` Ard Biesheuvel
2020-08-21 12:30 ` Will Deacon
2020-08-22 13:47 ` Ard Biesheuvel
2020-08-24 15:24 ` Jessica Yu
2020-08-25 1:54 ` Masahiro Yamada
2020-08-31 9:46 ` Jessica Yu
2020-08-31 10:42 ` Masahiro Yamada
2020-08-31 13:25 ` Ard Biesheuvel
2020-08-31 15:31 ` Jessica Yu
2020-08-31 15:46 ` Masahiro Yamada
2020-09-03 12:37 ` Jessica Yu
2020-09-01 12:51 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811212908.GB5637@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ardb@kernel.org \
--cc=jeyu@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbenes@suse.cz \
--cc=mchehab+huawei@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).