linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300
@ 2020-08-12  7:31 John Ogness
  2020-08-12 21:39 ` Steven Rostedt
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: John Ogness @ 2020-08-12  7:31 UTC (permalink / raw)
  To: Petr Mladek
  Cc: Sergey Senozhatsky, Sergey Senozhatsky, Steven Rostedt,
	Linus Torvalds, Greg Kroah-Hartman, linux-kernel

The .bss section for the h8300 is relatively small. A value of
CONFIG_LOG_BUF_SHIFT that is larger than 19 will create a static
printk ringbuffer that is too large. Limit the range appropriately
for the H8300.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
 based on next-20200811

 init/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index d6a0b31b13dc..2a5df1cf838c 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -682,7 +682,8 @@ config IKHEADERS
 
 config LOG_BUF_SHIFT
 	int "Kernel log buffer size (16 => 64KB, 17 => 128KB)"
-	range 12 25
+	range 12 25 if !H8300
+	range 12 19 if H8300
 	default 17
 	depends on PRINTK
 	help
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300
  2020-08-12  7:31 [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300 John Ogness
@ 2020-08-12 21:39 ` Steven Rostedt
  2020-08-13  1:46 ` Sergey Senozhatsky
  2020-08-13 13:20 ` Petr Mladek
  2 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2020-08-12 21:39 UTC (permalink / raw)
  To: John Ogness
  Cc: Petr Mladek, Sergey Senozhatsky, Sergey Senozhatsky,
	Linus Torvalds, Greg Kroah-Hartman, linux-kernel

On Wed, 12 Aug 2020 09:37:22 +0206
John Ogness <john.ogness@linutronix.de> wrote:

> The .bss section for the h8300 is relatively small. A value of
> CONFIG_LOG_BUF_SHIFT that is larger than 19 will create a static
> printk ringbuffer that is too large. Limit the range appropriately
> for the H8300.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300
  2020-08-12  7:31 [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300 John Ogness
  2020-08-12 21:39 ` Steven Rostedt
@ 2020-08-13  1:46 ` Sergey Senozhatsky
  2020-08-13 13:20 ` Petr Mladek
  2 siblings, 0 replies; 4+ messages in thread
From: Sergey Senozhatsky @ 2020-08-13  1:46 UTC (permalink / raw)
  To: John Ogness
  Cc: Petr Mladek, Sergey Senozhatsky, Sergey Senozhatsky,
	Steven Rostedt, Linus Torvalds, Greg Kroah-Hartman, linux-kernel

On (20/08/12 09:37), John Ogness wrote:
> The .bss section for the h8300 is relatively small. A value of
> CONFIG_LOG_BUF_SHIFT that is larger than 19 will create a static
> printk ringbuffer that is too large. Limit the range appropriately
> for the H8300.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300
  2020-08-12  7:31 [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300 John Ogness
  2020-08-12 21:39 ` Steven Rostedt
  2020-08-13  1:46 ` Sergey Senozhatsky
@ 2020-08-13 13:20 ` Petr Mladek
  2 siblings, 0 replies; 4+ messages in thread
From: Petr Mladek @ 2020-08-13 13:20 UTC (permalink / raw)
  To: John Ogness
  Cc: Sergey Senozhatsky, Sergey Senozhatsky, Steven Rostedt,
	Linus Torvalds, Greg Kroah-Hartman, linux-kernel

On Wed 2020-08-12 09:37:22, John Ogness wrote:
> The .bss section for the h8300 is relatively small. A value of
> CONFIG_LOG_BUF_SHIFT that is larger than 19 will create a static
> printk ringbuffer that is too large. Limit the range appropriately
> for the H8300.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

This patch is committed in printk/linux.git, branch printk-rework.

Best Regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-13 13:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12  7:31 [PATCH][next] printk: reduce LOG_BUF_SHIFT range for H8300 John Ogness
2020-08-12 21:39 ` Steven Rostedt
2020-08-13  1:46 ` Sergey Senozhatsky
2020-08-13 13:20 ` Petr Mladek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).