* [PATCH 0/2] for-5.9rc1 dyndbg fixes
@ 2020-08-14 16:07 Jim Cromie
2020-08-14 16:07 ` [PATCH 1/2] dyndbg: add decl for exported ddebug_exec_queries() Jim Cromie
2020-08-14 16:08 ` [PATCH 2/2] dyndbg: give %3u width in pr-format, cosmetic only Jim Cromie
0 siblings, 2 replies; 3+ messages in thread
From: Jim Cromie @ 2020-08-14 16:07 UTC (permalink / raw)
To: jbaron, gregkh, linux-kernel; +Cc: Jim Cromie
2 items for v5.9-rc1
fix sparse complaint about exported ddebug_exec_queries
fixed width format %3u
Jim Cromie (2):
dyndbg: add decl for exported ddebug_exec_queries()
dyndbg: give %3u width in pr-format, cosmetic only
include/linux/dynamic_debug.h | 3 +++
lib/dynamic_debug.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] dyndbg: add decl for exported ddebug_exec_queries()
2020-08-14 16:07 [PATCH 0/2] for-5.9rc1 dyndbg fixes Jim Cromie
@ 2020-08-14 16:07 ` Jim Cromie
2020-08-14 16:08 ` [PATCH 2/2] dyndbg: give %3u width in pr-format, cosmetic only Jim Cromie
1 sibling, 0 replies; 3+ messages in thread
From: Jim Cromie @ 2020-08-14 16:07 UTC (permalink / raw)
To: jbaron, gregkh, linux-kernel; +Cc: Jim Cromie
59cf47e7df31 dyndbg: export ddebug_exec_queries
elicited a sparse complaint. Add declaration to header file.
I skipped the kerneldoc for now, unsure where it should go.
Ive seen it in .c files, Im leaning that way.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/linux/dynamic_debug.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index aa9ff9e1c0b3..61eb80c726bf 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -6,6 +6,9 @@
#include <linux/jump_label.h>
#endif
+/* exported for module authors to exercise >control */
+int ddebug_exec_queries(char *query, const char *modname);
+
/*
* An instance of this structure is created in a special
* ELF section at every dynamic debug callsite. At runtime,
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] dyndbg: give %3u width in pr-format, cosmetic only
2020-08-14 16:07 [PATCH 0/2] for-5.9rc1 dyndbg fixes Jim Cromie
2020-08-14 16:07 ` [PATCH 1/2] dyndbg: add decl for exported ddebug_exec_queries() Jim Cromie
@ 2020-08-14 16:08 ` Jim Cromie
1 sibling, 0 replies; 3+ messages in thread
From: Jim Cromie @ 2020-08-14 16:08 UTC (permalink / raw)
To: jbaron, gregkh, linux-kernel; +Cc: Jim Cromie
Specify the print-width so log entries line up nicely.
no functional changes.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 1d012e597cc3..01b7d0210412 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -947,7 +947,7 @@ int ddebug_add_module(struct _ddebug *tab, unsigned int n,
list_add(&dt->link, &ddebug_tables);
mutex_unlock(&ddebug_lock);
- v2pr_info("%u debug prints in module %s\n", n, dt->mod_name);
+ v2pr_info("%3u debug prints in module %s\n", n, dt->mod_name);
return 0;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-14 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 16:07 [PATCH 0/2] for-5.9rc1 dyndbg fixes Jim Cromie
2020-08-14 16:07 ` [PATCH 1/2] dyndbg: add decl for exported ddebug_exec_queries() Jim Cromie
2020-08-14 16:08 ` [PATCH 2/2] dyndbg: give %3u width in pr-format, cosmetic only Jim Cromie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).