* [PATCH v8 0/2] shtc1: add support for device tree bindings @ 2020-08-15 1:22 Chris Ruehl 2020-08-15 1:22 ` [PATCH v8 1/2] hwmon: " Chris Ruehl 2020-08-15 1:22 ` [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml Chris Ruehl 0 siblings, 2 replies; 6+ messages in thread From: Chris Ruehl @ 2020-08-15 1:22 UTC (permalink / raw) To: Chris Ruehl Cc: Jack Lo, devicetree, Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel Add support for DTS bindings to the shtc driver The patches add the compatible table and of_property_read_bool to the shtc1.c. Newly created Yaml document has been released to the Documentation/devicetree/hwmon/sensirion,shtc1.yaml Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> --- Version 8 sensirion,shtc1.yaml: Correction in commit text s/_/-/ (sensirion,low-precision) Maintainer my full name Add additionalProperties: false Simplify example i2c1 { -> i2c { Version 7 make dt_binding_check warnings, missing #address-cells, #size-cells in example dtschema-2020.7.dev3+g8fd8ce7 Version 6 fix dt_binding_check: missing ';' in examples Version 5 devicetree/driver-source: name conversion sensirion,low-precision sensirion,blocking-io use const: 0x70 with the reg: Version 4 Fix errors report by make dt_binding_check (devicetree) Set maintainers for the yaml document to my own. Version 3 Fix errors report with checkpatch.pl Correct logic, add (!) when check for sensirion,low_precision Version 2 remove the #ifdef CONFIG_OF ignore platform data if dev->of_node is valid use boolean only therefor use sensirion,low_precise to fit the logic add missing driver.of_match_table entry Version 1 initial version ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v8 1/2] hwmon: shtc1: add support for device tree bindings 2020-08-15 1:22 [PATCH v8 0/2] shtc1: add support for device tree bindings Chris Ruehl @ 2020-08-15 1:22 ` Chris Ruehl 2020-08-21 18:39 ` Guenter Roeck 2020-08-15 1:22 ` [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml Chris Ruehl 1 sibling, 1 reply; 6+ messages in thread From: Chris Ruehl @ 2020-08-15 1:22 UTC (permalink / raw) To: Chris Ruehl Cc: Jack Lo, devicetree, Guenter Roeck, Jean Delvare, linux-hwmon, linux-kernel Add support for DTS bindings for the sensirion shtc1,shtw1 and shtc3. Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> Reviewed-by: Guenter Roeck <linux@roeck-us.net> --- v8: no change drivers/hwmon/shtc1.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c index a0078ccede03..7993a5ff8768 100644 --- a/drivers/hwmon/shtc1.c +++ b/drivers/hwmon/shtc1.c @@ -14,6 +14,7 @@ #include <linux/err.h> #include <linux/delay.h> #include <linux/platform_data/shtc1.h> +#include <linux/of.h> /* commands (high precision mode) */ static const unsigned char shtc1_cmd_measure_blocking_hpm[] = { 0x7C, 0xA2 }; @@ -196,6 +197,7 @@ static int shtc1_probe(struct i2c_client *client, enum shtcx_chips chip = id->driver_data; struct i2c_adapter *adap = client->adapter; struct device *dev = &client->dev; + struct device_node *np = dev->of_node; if (!i2c_check_functionality(adap, I2C_FUNC_I2C)) { dev_err(dev, "plain i2c transactions not supported\n"); @@ -233,8 +235,14 @@ static int shtc1_probe(struct i2c_client *client, data->client = client; data->chip = chip; - if (client->dev.platform_data) - data->setup = *(struct shtc1_platform_data *)dev->platform_data; + if (np) { + data->setup.blocking_io = of_property_read_bool(np, "sensirion,blocking-io"); + data->setup.high_precision = !of_property_read_bool(np, "sensicon,low-precision"); + } else { + if (client->dev.platform_data) + data->setup = *(struct shtc1_platform_data *)dev->platform_data; + } + shtc1_select_command(data); mutex_init(&data->update_lock); @@ -257,8 +265,19 @@ static const struct i2c_device_id shtc1_id[] = { }; MODULE_DEVICE_TABLE(i2c, shtc1_id); +static const struct of_device_id shtc1_of_match[] = { + { .compatible = "sensirion,shtc1" }, + { .compatible = "sensirion,shtw1" }, + { .compatible = "sensirion,shtc3" }, + { } +}; +MODULE_DEVICE_TABLE(of, shtc1_of_match); + static struct i2c_driver shtc1_i2c_driver = { - .driver.name = "shtc1", + .driver = { + .name = "shtc1", + .of_match_table = shtc1_of_match, + }, .probe = shtc1_probe, .id_table = shtc1_id, }; -- 2.20.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v8 1/2] hwmon: shtc1: add support for device tree bindings 2020-08-15 1:22 ` [PATCH v8 1/2] hwmon: " Chris Ruehl @ 2020-08-21 18:39 ` Guenter Roeck 0 siblings, 0 replies; 6+ messages in thread From: Guenter Roeck @ 2020-08-21 18:39 UTC (permalink / raw) To: Chris Ruehl; +Cc: Jack Lo, devicetree, Jean Delvare, linux-hwmon, linux-kernel On Sat, Aug 15, 2020 at 09:22:26AM +0800, Chris Ruehl wrote: > Add support for DTS bindings for the sensirion shtc1,shtw1 and shtc3. > > Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> > Reviewed-by: Guenter Roeck <linux@roeck-us.net> Applied. Thanks, Guenter > --- > v8: no change > > drivers/hwmon/shtc1.c | 25 ++++++++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c > index a0078ccede03..7993a5ff8768 100644 > --- a/drivers/hwmon/shtc1.c > +++ b/drivers/hwmon/shtc1.c > @@ -14,6 +14,7 @@ > #include <linux/err.h> > #include <linux/delay.h> > #include <linux/platform_data/shtc1.h> > +#include <linux/of.h> > > /* commands (high precision mode) */ > static const unsigned char shtc1_cmd_measure_blocking_hpm[] = { 0x7C, 0xA2 }; > @@ -196,6 +197,7 @@ static int shtc1_probe(struct i2c_client *client, > enum shtcx_chips chip = id->driver_data; > struct i2c_adapter *adap = client->adapter; > struct device *dev = &client->dev; > + struct device_node *np = dev->of_node; > > if (!i2c_check_functionality(adap, I2C_FUNC_I2C)) { > dev_err(dev, "plain i2c transactions not supported\n"); > @@ -233,8 +235,14 @@ static int shtc1_probe(struct i2c_client *client, > data->client = client; > data->chip = chip; > > - if (client->dev.platform_data) > - data->setup = *(struct shtc1_platform_data *)dev->platform_data; > + if (np) { > + data->setup.blocking_io = of_property_read_bool(np, "sensirion,blocking-io"); > + data->setup.high_precision = !of_property_read_bool(np, "sensicon,low-precision"); > + } else { > + if (client->dev.platform_data) > + data->setup = *(struct shtc1_platform_data *)dev->platform_data; > + } > + > shtc1_select_command(data); > mutex_init(&data->update_lock); > > @@ -257,8 +265,19 @@ static const struct i2c_device_id shtc1_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, shtc1_id); > > +static const struct of_device_id shtc1_of_match[] = { > + { .compatible = "sensirion,shtc1" }, > + { .compatible = "sensirion,shtw1" }, > + { .compatible = "sensirion,shtc3" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, shtc1_of_match); > + > static struct i2c_driver shtc1_i2c_driver = { > - .driver.name = "shtc1", > + .driver = { > + .name = "shtc1", > + .of_match_table = shtc1_of_match, > + }, > .probe = shtc1_probe, > .id_table = shtc1_id, > }; ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml 2020-08-15 1:22 [PATCH v8 0/2] shtc1: add support for device tree bindings Chris Ruehl 2020-08-15 1:22 ` [PATCH v8 1/2] hwmon: " Chris Ruehl @ 2020-08-15 1:22 ` Chris Ruehl 2020-08-17 19:41 ` Rob Herring 2020-08-21 18:40 ` Guenter Roeck 1 sibling, 2 replies; 6+ messages in thread From: Chris Ruehl @ 2020-08-15 1:22 UTC (permalink / raw) To: Chris Ruehl Cc: Jack Lo, devicetree, Jean Delvare, Guenter Roeck, Rob Herring, linux-hwmon, linux-kernel Add documentation for the newly added DTS support in the shtc1 driver. To align with the drivers logic to have high precision by default a boolean sensirion,low-precision is used to switch to low precision. Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> --- .../bindings/hwmon/sensirion,shtc1.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml new file mode 100644 index 000000000000..c523a1beb2b7 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/sensirion,shtc1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sensirion SHTC1 Humidity and Temperature Sensor IC + +maintainers: + - Christopher Ruehl chris.ruehl@gtsys.com.hk + +description: | + The SHTC1, SHTW1 and SHTC3 are digital humidity and temperature sensor + designed especially for battery-driven high-volume consumer electronics + applications. + For further information refere to Documentation/hwmon/shtc1.rst + + This binding document describes the binding for the hardware monitor + portion of the driver. + +properties: + compatible: + enum: + - sensirion,shtc1 + - sensirion,shtw1 + - sensirion,shtc3 + + reg: + const: 0x70 + + sensirion,blocking-io: + $ref: /schemas/types.yaml#definitions/flag + description: + If set, the driver hold the i2c bus until measurement is finished. + + sensirion,low-precision: + $ref: /schemas/types.yaml#definitions/flag + description: + If set, the sensor aquire data with low precision (not recommended). + The driver aquire data with high precision by default. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <400000>; + + shtc3@70 { + compatible = "sensirion,shtc3"; + reg = <0x70>; + sensirion,blocking-io; + }; + }; +... -- 2.20.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml 2020-08-15 1:22 ` [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml Chris Ruehl @ 2020-08-17 19:41 ` Rob Herring 2020-08-21 18:40 ` Guenter Roeck 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2020-08-17 19:41 UTC (permalink / raw) To: Chris Ruehl Cc: Rob Herring, devicetree, Jean Delvare, linux-hwmon, linux-kernel, Jack Lo, Guenter Roeck On Sat, 15 Aug 2020 09:22:27 +0800, Chris Ruehl wrote: > Add documentation for the newly added DTS support in the shtc1 driver. > To align with the drivers logic to have high precision by default > a boolean sensirion,low-precision is used to switch to low precision. > > Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> > --- > .../bindings/hwmon/sensirion,shtc1.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml 2020-08-15 1:22 ` [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml Chris Ruehl 2020-08-17 19:41 ` Rob Herring @ 2020-08-21 18:40 ` Guenter Roeck 1 sibling, 0 replies; 6+ messages in thread From: Guenter Roeck @ 2020-08-21 18:40 UTC (permalink / raw) To: Chris Ruehl Cc: Jack Lo, devicetree, Jean Delvare, Rob Herring, linux-hwmon, linux-kernel On Sat, Aug 15, 2020 at 09:22:27AM +0800, Chris Ruehl wrote: > Add documentation for the newly added DTS support in the shtc1 driver. > To align with the drivers logic to have high precision by default > a boolean sensirion,low-precision is used to switch to low precision. > > Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> > Reviewed-by: Rob Herring <robh@kernel.org> Applied. Thanks, Guenter > --- > .../bindings/hwmon/sensirion,shtc1.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml > new file mode 100644 > index 000000000000..c523a1beb2b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/sensirion,shtc1.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sensirion SHTC1 Humidity and Temperature Sensor IC > + > +maintainers: > + - Christopher Ruehl chris.ruehl@gtsys.com.hk > + > +description: | > + The SHTC1, SHTW1 and SHTC3 are digital humidity and temperature sensor > + designed especially for battery-driven high-volume consumer electronics > + applications. > + For further information refere to Documentation/hwmon/shtc1.rst > + > + This binding document describes the binding for the hardware monitor > + portion of the driver. > + > +properties: > + compatible: > + enum: > + - sensirion,shtc1 > + - sensirion,shtw1 > + - sensirion,shtc3 > + > + reg: > + const: 0x70 > + > + sensirion,blocking-io: > + $ref: /schemas/types.yaml#definitions/flag > + description: > + If set, the driver hold the i2c bus until measurement is finished. > + > + sensirion,low-precision: > + $ref: /schemas/types.yaml#definitions/flag > + description: > + If set, the sensor aquire data with low precision (not recommended). > + The driver aquire data with high precision by default. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <400000>; > + > + shtc3@70 { > + compatible = "sensirion,shtc3"; > + reg = <0x70>; > + sensirion,blocking-io; > + }; > + }; > +... ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-21 18:40 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-15 1:22 [PATCH v8 0/2] shtc1: add support for device tree bindings Chris Ruehl 2020-08-15 1:22 ` [PATCH v8 1/2] hwmon: " Chris Ruehl 2020-08-21 18:39 ` Guenter Roeck 2020-08-15 1:22 ` [PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml Chris Ruehl 2020-08-17 19:41 ` Rob Herring 2020-08-21 18:40 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).