* [PATCH] scsi: aic7xxx: fix error code handling
@ 2020-08-16 7:02 Tong Zhang
2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Tong Zhang @ 2020-08-16 7:02 UTC (permalink / raw)
To: linux-kernel, linux-scsi, martin.petersen, jejb, hare; +Cc: ztong0001
ahc_linux_queue_recovery_cmd returns SUCCESS(0x2002) or FAIL(0x2003),
but the caller is checking error case using !=0
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index e7ccb8b80fc1..7bba961d1ae0 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -730,7 +730,7 @@ ahc_linux_abort(struct scsi_cmnd *cmd)
int error;
error = ahc_linux_queue_recovery_cmd(cmd, SCB_ABORT);
- if (error != 0)
+ if (error != SUCCESS)
printk("aic7xxx_abort returns 0x%x\n", error);
return (error);
}
@@ -744,7 +744,7 @@ ahc_linux_dev_reset(struct scsi_cmnd *cmd)
int error;
error = ahc_linux_queue_recovery_cmd(cmd, SCB_DEVICE_RESET);
- if (error != 0)
+ if (error != SUCCESS)
printk("aic7xxx_dev_reset returns 0x%x\n", error);
return (error);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: aic7xxx: fix error code handling
2020-08-16 7:02 [PATCH] scsi: aic7xxx: fix error code handling Tong Zhang
@ 2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-08-31 17:41 UTC (permalink / raw)
To: Tong Zhang, jejb, linux-scsi, hare, linux-kernel; +Cc: Martin K . Petersen
On Sun, 16 Aug 2020 03:02:42 -0400, Tong Zhang wrote:
> ahc_linux_queue_recovery_cmd returns SUCCESS(0x2002) or FAIL(0x2003),
> but the caller is checking error case using !=0
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: aic7xxx: Fix error code handling
https://git.kernel.org/mkp/scsi/c/715f43c66c45
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-31 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-16 7:02 [PATCH] scsi: aic7xxx: fix error code handling Tong Zhang
2020-08-31 17:41 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).