* [PATCH] ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy
@ 2020-08-17 3:04 Chris Healy
2020-08-22 19:59 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Chris Healy @ 2020-08-17 3:04 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx, linux,
davem, philippe.schenker, andrew, devicetree, linux-arm-kernel,
linux-kernel
Cc: Chris Healy
From: Chris Healy <cphealy@gmail.com>
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.
Fix it by switching to phy-mode = "rgmii-id".
Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
arch/arm/boot/dts/imx7d-zii-rmu2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7d-zii-rmu2.dts b/arch/arm/boot/dts/imx7d-zii-rmu2.dts
index e5e20b07f184..7cb6153fc650 100644
--- a/arch/arm/boot/dts/imx7d-zii-rmu2.dts
+++ b/arch/arm/boot/dts/imx7d-zii-rmu2.dts
@@ -58,7 +58,7 @@ &fec1 {
<&clks IMX7D_ENET1_TIME_ROOT_CLK>;
assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
assigned-clock-rates = <0>, <100000000>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-handle = <&fec1_phy>;
status = "okay";
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy
2020-08-17 3:04 [PATCH] ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy Chris Healy
@ 2020-08-22 19:59 ` Fabio Estevam
2020-08-22 20:06 ` Chris Healy
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2020-08-22 19:59 UTC (permalink / raw)
To: Chris Healy
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
NXP Linux Team, Oleksij Rempel, David S. Miller,
Philippe Schenker, Andrew Lunn,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
Hi Chris,
On Mon, Aug 17, 2020 at 12:04 AM Chris Healy <cphealy@gmail.com> wrote:
>
> From: Chris Healy <cphealy@gmail.com>
>
> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.
>
> Fix it by switching to phy-mode = "rgmii-id".
The patch looks good, but the commit log could be improved to explain
more about the reason for the breakage.
Please check commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X
phy-mode") as a reference.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy
2020-08-22 19:59 ` Fabio Estevam
@ 2020-08-22 20:06 ` Chris Healy
0 siblings, 0 replies; 3+ messages in thread
From: Chris Healy @ 2020-08-22 20:06 UTC (permalink / raw)
To: Fabio Estevam
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
NXP Linux Team, Oleksij Rempel, David S. Miller,
Philippe Schenker, Andrew Lunn,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
On Sat, Aug 22, 2020 at 12:59 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> On Mon, Aug 17, 2020 at 12:04 AM Chris Healy <cphealy@gmail.com> wrote:
> >
> > From: Chris Healy <cphealy@gmail.com>
> >
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> > KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.
> >
> > Fix it by switching to phy-mode = "rgmii-id".
>
> The patch looks good, but the commit log could be improved to explain
> more about the reason for the breakage.
>
> Please check commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X
> phy-mode") as a reference.
Sounds good, I'll improve the commit log in v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-22 20:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 3:04 [PATCH] ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy Chris Healy
2020-08-22 19:59 ` Fabio Estevam
2020-08-22 20:06 ` Chris Healy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).