* [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe
@ 2020-08-13 16:11 Stephen Kitt
2020-08-14 11:39 ` Corentin Labbe
2020-08-17 8:45 ` Corentin Labbe
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Kitt @ 2020-08-13 16:11 UTC (permalink / raw)
To: Corentin Labbe, Jean Delvare, Guenter Roeck, linux-hwmon
Cc: linux-kernel, Stephen Kitt
This driver doesn't use the id information provided by the old i2c
probe function, so it can trivially be converted to the simple
("probe_new") form.
Signed-off-by: Stephen Kitt <steve@sk2.org>
---
drivers/hwmon/adm1029.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
index f7752a5bef31..50b1df7b008c 100644
--- a/drivers/hwmon/adm1029.c
+++ b/drivers/hwmon/adm1029.c
@@ -352,8 +352,7 @@ static int adm1029_init_client(struct i2c_client *client)
return 1;
}
-static int adm1029_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int adm1029_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct adm1029_data *data;
@@ -390,7 +389,7 @@ static struct i2c_driver adm1029_driver = {
.driver = {
.name = "adm1029",
},
- .probe = adm1029_probe,
+ .probe_new = adm1029_probe,
.id_table = adm1029_id,
.detect = adm1029_detect,
.address_list = normal_i2c,
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe
2020-08-13 16:11 [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe Stephen Kitt
@ 2020-08-14 11:39 ` Corentin Labbe
2020-08-17 8:45 ` Corentin Labbe
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2020-08-14 11:39 UTC (permalink / raw)
To: Stephen Kitt; +Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel
On Thu, Aug 13, 2020 at 06:11:29PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
> drivers/hwmon/adm1029.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
> index f7752a5bef31..50b1df7b008c 100644
> --- a/drivers/hwmon/adm1029.c
> +++ b/drivers/hwmon/adm1029.c
> @@ -352,8 +352,7 @@ static int adm1029_init_client(struct i2c_client *client)
> return 1;
> }
>
> -static int adm1029_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int adm1029_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct adm1029_data *data;
> @@ -390,7 +389,7 @@ static struct i2c_driver adm1029_driver = {
> .driver = {
> .name = "adm1029",
> },
> - .probe = adm1029_probe,
> + .probe_new = adm1029_probe,
> .id_table = adm1029_id,
> .detect = adm1029_detect,
> .address_list = normal_i2c,
> --
> 2.25.4
>
Hello
Acked-by: Corentin LABBE <clabbe.montjoie@gmail.com>
But please give me a few day to test it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe
2020-08-13 16:11 [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe Stephen Kitt
2020-08-14 11:39 ` Corentin Labbe
@ 2020-08-17 8:45 ` Corentin Labbe
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2020-08-17 8:45 UTC (permalink / raw)
To: Stephen Kitt; +Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel
On Thu, Aug 13, 2020 at 06:11:29PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
> drivers/hwmon/adm1029.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
> index f7752a5bef31..50b1df7b008c 100644
> --- a/drivers/hwmon/adm1029.c
> +++ b/drivers/hwmon/adm1029.c
> @@ -352,8 +352,7 @@ static int adm1029_init_client(struct i2c_client *client)
> return 1;
> }
>
> -static int adm1029_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int adm1029_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct adm1029_data *data;
> @@ -390,7 +389,7 @@ static struct i2c_driver adm1029_driver = {
> .driver = {
> .name = "adm1029",
> },
> - .probe = adm1029_probe,
> + .probe_new = adm1029_probe,
> .id_table = adm1029_id,
> .detect = adm1029_detect,
> .address_list = normal_i2c,
> --
> 2.25.4
>
Hello
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-17 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-13 16:11 [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe Stephen Kitt
2020-08-14 11:39 ` Corentin Labbe
2020-08-17 8:45 ` Corentin Labbe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).