linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM64: vdso32: Install vdso32 from vdso_install
@ 2020-08-18  1:49 Stephen Boyd
  2020-08-21 10:51 ` Will Deacon
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Stephen Boyd @ 2020-08-18  1:49 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon; +Cc: linux-kernel, Vincenzo Frascino

Add the 32-bit vdso Makefile to the vdso_install rule so that 'make
vdso_install' installs the 32-bit compat vdso when it is compiled.

Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Fixes: a7f71a2c8903 ("arm64: compat: Add vDSO")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/Makefile               | 1 +
 arch/arm64/kernel/vdso32/Makefile | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 55bc8546d9c7..b45f0124cc16 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -165,6 +165,7 @@ zinstall install:
 PHONY += vdso_install
 vdso_install:
 	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso $@
+	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso32 $@
 
 # We use MRPROPER_FILES and CLEAN_FILES now
 archclean:
diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile
index 5139a5f19256..d6adb4677c25 100644
--- a/arch/arm64/kernel/vdso32/Makefile
+++ b/arch/arm64/kernel/vdso32/Makefile
@@ -208,7 +208,7 @@ quiet_cmd_vdsosym = VDSOSYM $@
       cmd_vdsosym = $(NM) $< | $(gen-vdsosym) | LC_ALL=C sort > $@
 
 # Install commands for the unstripped file
-quiet_cmd_vdso_install = INSTALL $@
+quiet_cmd_vdso_install = INSTALL32 $@
       cmd_vdso_install = cp $(obj)/$@.dbg $(MODLIB)/vdso/vdso32.so
 
 vdso.so: $(obj)/vdso.so.dbg

base-commit: 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
-- 
Sent by a computer, using git, on the internet


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM64: vdso32: Install vdso32 from vdso_install
  2020-08-18  1:49 [PATCH] ARM64: vdso32: Install vdso32 from vdso_install Stephen Boyd
@ 2020-08-21 10:51 ` Will Deacon
  2020-08-21 10:56 ` Vincenzo Frascino
  2020-08-21 18:15 ` Catalin Marinas
  2 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2020-08-21 10:51 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Catalin Marinas, linux-kernel, Vincenzo Frascino

On Mon, Aug 17, 2020 at 06:49:50PM -0700, Stephen Boyd wrote:
> Add the 32-bit vdso Makefile to the vdso_install rule so that 'make
> vdso_install' installs the 32-bit compat vdso when it is compiled.
> 
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Fixes: a7f71a2c8903 ("arm64: compat: Add vDSO")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  arch/arm64/Makefile               | 1 +
>  arch/arm64/kernel/vdso32/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)

Acked-by: Will Deacon <will@kernel.org>

Will

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM64: vdso32: Install vdso32 from vdso_install
  2020-08-18  1:49 [PATCH] ARM64: vdso32: Install vdso32 from vdso_install Stephen Boyd
  2020-08-21 10:51 ` Will Deacon
@ 2020-08-21 10:56 ` Vincenzo Frascino
  2020-08-21 18:15 ` Catalin Marinas
  2 siblings, 0 replies; 4+ messages in thread
From: Vincenzo Frascino @ 2020-08-21 10:56 UTC (permalink / raw)
  To: Stephen Boyd, Catalin Marinas, Will Deacon; +Cc: linux-kernel

On 8/18/20 2:49 AM, Stephen Boyd wrote:
> Add the 32-bit vdso Makefile to the vdso_install rule so that 'make
> vdso_install' installs the 32-bit compat vdso when it is compiled.
> 
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Fixes: a7f71a2c8903 ("arm64: compat: Add vDSO")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  arch/arm64/Makefile               | 1 +
>  arch/arm64/kernel/vdso32/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 55bc8546d9c7..b45f0124cc16 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -165,6 +165,7 @@ zinstall install:
>  PHONY += vdso_install
>  vdso_install:
>  	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso $@
> +	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso32 $@
>  
>  # We use MRPROPER_FILES and CLEAN_FILES now
>  archclean:
> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile
> index 5139a5f19256..d6adb4677c25 100644
> --- a/arch/arm64/kernel/vdso32/Makefile
> +++ b/arch/arm64/kernel/vdso32/Makefile
> @@ -208,7 +208,7 @@ quiet_cmd_vdsosym = VDSOSYM $@
>        cmd_vdsosym = $(NM) $< | $(gen-vdsosym) | LC_ALL=C sort > $@
>  
>  # Install commands for the unstripped file
> -quiet_cmd_vdso_install = INSTALL $@
> +quiet_cmd_vdso_install = INSTALL32 $@
>        cmd_vdso_install = cp $(obj)/$@.dbg $(MODLIB)/vdso/vdso32.so
>  
>  vdso.so: $(obj)/vdso.so.dbg
> 
> base-commit: 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
> 

-- 
Regards,
Vincenzo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM64: vdso32: Install vdso32 from vdso_install
  2020-08-18  1:49 [PATCH] ARM64: vdso32: Install vdso32 from vdso_install Stephen Boyd
  2020-08-21 10:51 ` Will Deacon
  2020-08-21 10:56 ` Vincenzo Frascino
@ 2020-08-21 18:15 ` Catalin Marinas
  2 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2020-08-21 18:15 UTC (permalink / raw)
  To: linux-arm-kernel, Marc Zyngier, Will Deacon, Stephen Boyd
  Cc: dianders, kernel-team, Sai Prakash Ranjan, Suzuki K Poulose,
	Vincenzo Frascino, linux-kernel

On Mon, 17 Aug 2020 18:49:50 -0700, Stephen Boyd wrote:
> Add the 32-bit vdso Makefile to the vdso_install rule so that 'make
> vdso_install' installs the 32-bit compat vdso when it is compiled.

Applied to arm64 (for-next/fixes), thanks!

[1/1] ARM64: vdso32: Install vdso32 from vdso_install
      https://git.kernel.org/arm64/c/8d75785a8142

-- 
Catalin


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-21 18:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18  1:49 [PATCH] ARM64: vdso32: Install vdso32 from vdso_install Stephen Boyd
2020-08-21 10:51 ` Will Deacon
2020-08-21 10:56 ` Vincenzo Frascino
2020-08-21 18:15 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).