* [PATCH] memory: tegra: Correct shift value of apew
@ 2020-08-18 9:51 Nicolin Chen
2020-08-20 15:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Nicolin Chen @ 2020-08-18 9:51 UTC (permalink / raw)
To: thierry.reding; +Cc: krzk, jonathanh, linux-kernel, linux-tegra
According to Tegra X1 (Tegra210) TRM, the APEW field is between
[23:16] so the shift bit for apew should be 16 accordingly.
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
drivers/memory/tegra/tegra210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/tegra/tegra210.c b/drivers/memory/tegra/tegra210.c
index eab4bc01c8bc..51b537cfa5a7 100644
--- a/drivers/memory/tegra/tegra210.c
+++ b/drivers/memory/tegra/tegra210.c
@@ -842,7 +842,7 @@ static const struct tegra_mc_client tegra210_mc_clients[] = {
},
.la = {
.reg = 0x3dc,
- .shift = 0,
+ .shift = 16,
.mask = 0xff,
.def = 0x80,
},
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: tegra: Correct shift value of apew
2020-08-18 9:51 [PATCH] memory: tegra: Correct shift value of apew Nicolin Chen
@ 2020-08-20 15:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-20 15:24 UTC (permalink / raw)
To: Nicolin Chen; +Cc: thierry.reding, jonathanh, linux-kernel, linux-tegra
On Tue, Aug 18, 2020 at 02:51:21AM -0700, Nicolin Chen wrote:
> According to Tegra X1 (Tegra210) TRM, the APEW field is between
> [23:16] so the shift bit for apew should be 16 accordingly.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> drivers/memory/tegra/tegra210.c | 2 +-
Thanks, applied to drivers/memory.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-20 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 9:51 [PATCH] memory: tegra: Correct shift value of apew Nicolin Chen
2020-08-20 15:24 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).