[PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

[PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

[Stephen Kitt]

This driver doesn't use the id information provided by the old i2c
probe function, so it can trivially be converted to the simple
("probe_new") form.

Signed-off-by: Stephen Kitt <steve@sk2.org>
---
 drivers/hwmon/adm1177.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/hwmon/adm1177.c b/drivers/hwmon/adm1177.c
index d314223a404a..6e8bb661894b 100644
--- a/drivers/hwmon/adm1177.c
+++ b/drivers/hwmon/adm1177.c
@@ -196,8 +196,7 @@ static void adm1177_remove(void *data)
 	regulator_disable(st->reg);
 }
 
-static int adm1177_probe(struct i2c_client *client,
-			 const struct i2c_device_id *id)
+static int adm1177_probe(struct i2c_client *client)
 {
 	struct device *dev = &client->dev;
 	struct device *hwmon_dev;
@@ -277,7 +276,7 @@ static struct i2c_driver adm1177_driver = {
 		.name = "adm1177",
 		.of_match_table = adm1177_dt_ids,
 	},
-	.probe = adm1177_probe,
+	.probe_new = adm1177_probe,
 	.id_table = adm1177_id,
 };
 module_i2c_driver(adm1177_driver);
-- 
2.25.4

Re: [PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

[Guenter Roeck]

On Thu, Aug 13, 2020 at 06:09:58PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>

I'll apply the entire series, but please don't use entire path names
as tag in the future but follow bubsystem rules.

Thanks,
Guenter

> ---
>  drivers/hwmon/adm1177.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/adm1177.c b/drivers/hwmon/adm1177.c
> index d314223a404a..6e8bb661894b 100644
> --- a/drivers/hwmon/adm1177.c
> +++ b/drivers/hwmon/adm1177.c
> @@ -196,8 +196,7 @@ static void adm1177_remove(void *data)
>  	regulator_disable(st->reg);
>  }
>  
> -static int adm1177_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adm1177_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct device *hwmon_dev;
> @@ -277,7 +276,7 @@ static struct i2c_driver adm1177_driver = {
>  		.name = "adm1177",
>  		.of_match_table = adm1177_dt_ids,
>  	},
> -	.probe = adm1177_probe,
> +	.probe_new = adm1177_probe,
>  	.id_table = adm1177_id,
>  };
>  module_i2c_driver(adm1177_driver);

Re: [PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

[Stephen Kitt]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On Fri, 14 Aug 2020 08:13:58 -0700, Guenter Roeck <linux@roeck-us.net> wrote:
> On Thu, Aug 13, 2020 at 06:09:58PM +0200, Stephen Kitt wrote:
> > This driver doesn't use the id information provided by the old i2c
> > probe function, so it can trivially be converted to the simple
> > ("probe_new") form.
> > 
> > Signed-off-by: Stephen Kitt <steve@sk2.org>  
> 
> I'll apply the entire series, but please don't use entire path names
> as tag in the future but follow bubsystem rules.

Sorry about that, I’ll bear that in mind for the remaining hwmon patches (and
more generally).

Regards,

Stephen

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

[Guenter Roeck]

[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]

On 8/21/20 4:25 AM, Stephen Kitt wrote:
> On Fri, 14 Aug 2020 08:13:58 -0700, Guenter Roeck <linux@roeck-us.net> wrote:
>> On Thu, Aug 13, 2020 at 06:09:58PM +0200, Stephen Kitt wrote:
>>> This driver doesn't use the id information provided by the old i2c
>>> probe function, so it can trivially be converted to the simple
>>> ("probe_new") form.
>>>
>>> Signed-off-by: Stephen Kitt <steve@sk2.org>  
>>
>> I'll apply the entire series, but please don't use entire path names
>> as tag in the future but follow bubsystem rules.
> 

"bubsystem". Sigh. Me and my fat fingers.

Guenter


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]