From: David Miller <davem@davemloft.net>
To: Jianlin.Lv@arm.com
Cc: netdev@vger.kernel.org, kuba@kernel.org, Song.Zhu@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: Remove unnecessary intermediate variables
Date: Sat, 22 Aug 2020 12:33:15 -0700 (PDT) [thread overview]
Message-ID: <20200822.123315.787815838209253525.davem@davemloft.net> (raw)
In-Reply-To: <20200822020431.125732-1-Jianlin.Lv@arm.com>
From: Jianlin Lv <Jianlin.Lv@arm.com>
Date: Sat, 22 Aug 2020 10:04:31 +0800
> It is not necessary to use src/dst as an intermediate variable for
> assignment operation; Delete src/dst intermediate variables to avoid
> unnecessary variable declarations.
>
> Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
It keeps the line lengths within reasonable length, so these local
variables are fine.
Also, the appropriate subsystem prefix for this patch should be "vxlan: "
not "net: " in your Subject line. If someone is skimming the shortlog
in 'git' how will they tell where exactly in the networking your change
is being made?
Anyways, I'm not applying this, thanks.
next prev parent reply other threads:[~2020-08-22 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 2:04 [PATCH net-next] net: Remove unnecessary intermediate variables Jianlin Lv
2020-08-22 19:33 ` David Miller [this message]
2020-08-22 20:39 ` Joe Perches
2020-08-22 20:59 ` David Miller
2020-08-22 21:03 ` Joe Perches
2020-08-22 21:07 ` David Miller
2020-08-22 21:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822.123315.787815838209253525.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jianlin.Lv@arm.com \
--cc=Song.Zhu@arm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).