linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: Jianlin.Lv@arm.com, netdev@vger.kernel.org, kuba@kernel.org,
	Song.Zhu@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: Remove unnecessary intermediate variables
Date: Sat, 22 Aug 2020 14:20:30 -0700	[thread overview]
Message-ID: <979bf21913a57f4f402fbd859891907a6ada6209.camel@perches.com> (raw)
In-Reply-To: <20200822.140758.1768310758210192749.davem@davemloft.net>

On Sat, 2020-08-22 at 14:07 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Sat, 22 Aug 2020 14:03:31 -0700
> 
> > The compiler didn't inline the code without it.
> 
> Then the compiler had a good reason for doing so,

The "good" word choice there is slightly dubious.
Compilers make bad decisions all the time.

> or it's a compiler bug that should be reported.

<shrug>

Or just behavioral changes between versions, or
even just random compiler decisions that causes
known unrepeatable compilation output.

That happens all the time.

If you want it just as static without the
inline/__always_inline marking, let me know.



      reply	other threads:[~2020-08-22 21:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-22  2:04 [PATCH net-next] net: Remove unnecessary intermediate variables Jianlin Lv
2020-08-22 19:33 ` David Miller
2020-08-22 20:39   ` Joe Perches
2020-08-22 20:59     ` David Miller
2020-08-22 21:03       ` Joe Perches
2020-08-22 21:07         ` David Miller
2020-08-22 21:20           ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=979bf21913a57f4f402fbd859891907a6ada6209.camel@perches.com \
    --to=joe@perches.com \
    --cc=Jianlin.Lv@arm.com \
    --cc=Song.Zhu@arm.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).